[Cronet] Cronet causes native crash on TEGRA devices due to use of NEON instructions |
|||||||
Issue descriptionChrome Android ARMv7 builds have recently switched to use arm_neon=1 arm_neon_optional=0 by default on Android/ARM32. This includes Cronet, and results in crash on initialization if device does not support NEON instructions (e.g. TEGRA chipset). The ARMv6 build doesn't appear to enable NEON instructions and could be used for compatibility purposes. We need to decide on the fix and apply it as soon as possible.
,
Mar 22 2016
The fix is to use arm_neon=0 for Cronet ARMv7 builders.
,
Jun 2 2016
Hi John, it seems that in switch of Cronet official builders from GYP to GN we've lost arm_neon=0 on ARMv7 builders, and that crashes on Tegra2 devices like Moto Xoom.
,
Jun 2 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/1a6d66978dab6da658acc365b6a67de04cf3cd21 commit 1a6d66978dab6da658acc365b6a67de04cf3cd21 Author: jbudorick <jbudorick@chromium.org> Date: Thu Jun 02 13:29:07 2016 [Android] Add disable_neon config. BUG= 594316 TBR=martiniss@chromium.org,bpastene@chromium.org Review-Url: https://codereview.chromium.org/2034623003 [modify] https://crrev.com/1a6d66978dab6da658acc365b6a67de04cf3cd21/scripts/slave/recipe_modules/chromium_android/chromium_config.py
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/7b13a2a065e02595dcc71ed697cf0c7335b9489b commit 7b13a2a065e02595dcc71ed697cf0c7335b9489b Author: jbudorick <jbudorick@chromium.org> Date: Thu Jun 02 14:33:37 2016 [Android] Add CONFIG_CTX to disable_neon config. BUG= 594316 TBR=martiniss@chromium.org,bpastene@chromium.org Review-Url: https://codereview.chromium.org/2034733002 [modify] https://crrev.com/7b13a2a065e02595dcc71ed697cf0c7335b9489b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
,
Jun 2 2016
Fixed on internal bots with https://chromereviews.googleplex.com/440227013/
,
Jun 2 2016
kerz@, would it be possible to build another official patch from branch 2739 (52.0.2739.6) to pick up these changes for cherry-picking?
,
Jun 2 2016
kerz probably won't be available today, so +amineer
,
Jun 2 2016
Just to be sure, Cronet builds are triggered whenever an Android build is kicked, right? If so I just scheduled the build, it should be starting shortly.
,
Jun 2 2016
Ah, cool, thanks!
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e4fc149dcad53be2674694e2685c4cac28a35a34 commit e4fc149dcad53be2674694e2685c4cac28a35a34 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 02 14:18:52 2016
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/03d597bba055b25a26371c7eff7f6100592d3685 commit 03d597bba055b25a26371c7eff7f6100592d3685 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 02 14:38:40 2016
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/30f9bd903a2f2b7ba9b6949388ea139a862370e3 commit 30f9bd903a2f2b7ba9b6949388ea139a862370e3 Author: jbudorick <jbudorick@google.com> Date: Thu Jun 02 15:17:34 2016 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 22 2016