New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594315 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit 21 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Developers are misusing blocking

Project Member Reported by sosa@chromium.org, Mar 12 2016

Issue description

Fallout from crbug.com/594224

Blocking should only be used for one test run to gate another (not to be confused with MUST PASS for build to be green).

Should fix documentation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e1f1a698dc755e963c3a56bc92a2092b5ae78f4c

commit e1f1a698dc755e963c3a56bc92a2092b5ae78f4c
Author: Chris Sosa <sosa@chromium.org>
Date: Fri Mar 11 20:38:19 2016

CBuildbot: fix and improve documentation for HWTestConfig blocking behavior.

The concept of blocking was introduced to allow some suites to block
whether or not we run others. This was mis-used in a few places and so
I've gone ahead and fleshed out documentation to be better.

Outside of documentation, it also didn't make sense when some tests were
scheduled before (but not blocking) and after as it always ran
blocking suites first (which wasn't documented). Instead I've changed
and documented blocking behavior to be a join which allows more flexible
scheduling.

BUG= chromium:594315 
TEST=Unitests.

Change-Id: I991e57422f170d4891dfd1bfed3582f68af06f1c
Reviewed-on: https://chromium-review.googlesource.com/332445
Commit-Ready: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>

[modify] https://crrev.com/e1f1a698dc755e963c3a56bc92a2092b5ae78f4c/cbuildbot/config_lib.py
[modify] https://crrev.com/e1f1a698dc755e963c3a56bc92a2092b5ae78f4c/cbuildbot/builders/simple_builders.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5851d2018a268db6ec8450abd453f59d773f8e12

commit 5851d2018a268db6ec8450abd453f59d773f8e12
Author: Chris Sosa <sosa@chromium.org>
Date: Tue Mar 15 22:04:10 2016

Re-land: CBuildbot: fix and improve documentation for HWTestConfig blocking behavior.

The concept of blocking was introduced to allow some suites
to block whether or not we run others. This was mis-used in a few
places and so I've gone ahead and fleshed out documentation to be
better.

Outside of documentation, it also didn't make sense when some tests were
scheduled before (but not blocking) and after as it always ran
blocking suites first (which wasn't documented). Instead I've changed
and documented blocking behavior to be a join which allows more
flexible scheduling.

BUG= chromium:594315 
TEST=Unitests + Additional unittest to catch original regression with blocking

Change-Id: Iafe68108c821313a624dde4a8499b5f2f7f10a89
Reviewed-on: https://chromium-review.googlesource.com/332861
Commit-Ready: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/config_lib.py
[modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/builders/simple_builders_unittest.py
[modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/builders/simple_builders.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/875f88b99540469ed9ed49472750141a2dc27fbb

commit 875f88b99540469ed9ed49472750141a2dc27fbb
Author: Chris Sosa <sosa@chromium.org>
Date: Sat Mar 12 02:11:50 2016

Fix mis-use of blocking in all configs.

Blocking needlessly serializes HWTest runs. Looks like many developers
used blocking when they meant critical (which is another bag of worms).
All suites should run in parallel unless calling them should actually
block others from running.

This should speed up many test runs when we have more devices in a pool
than we might need.

BUG= chromium:594315 
TEST=Unittests/visual so far. PSA and I talked with all test suite
owners who set blocking=True to get their consent.

Change-Id: I6230f7d6e285046f68dc66210ce543bb5851ed0a
Reviewed-on: https://chromium-review.googlesource.com/332217
Commit-Ready: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[modify] https://crrev.com/875f88b99540469ed9ed49472750141a2dc27fbb/cbuildbot/config_dump.json
[modify] https://crrev.com/875f88b99540469ed9ed49472750141a2dc27fbb/cbuildbot/chromeos_config.py

Comment 4 by benhenry@google.com, Apr 26 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment