Developers are misusing blocking |
|||||
Issue descriptionFallout from crbug.com/594224 Blocking should only be used for one test run to gate another (not to be confused with MUST PASS for build to be green). Should fix documentation.
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5851d2018a268db6ec8450abd453f59d773f8e12 commit 5851d2018a268db6ec8450abd453f59d773f8e12 Author: Chris Sosa <sosa@chromium.org> Date: Tue Mar 15 22:04:10 2016 Re-land: CBuildbot: fix and improve documentation for HWTestConfig blocking behavior. The concept of blocking was introduced to allow some suites to block whether or not we run others. This was mis-used in a few places and so I've gone ahead and fleshed out documentation to be better. Outside of documentation, it also didn't make sense when some tests were scheduled before (but not blocking) and after as it always ran blocking suites first (which wasn't documented). Instead I've changed and documented blocking behavior to be a join which allows more flexible scheduling. BUG= chromium:594315 TEST=Unitests + Additional unittest to catch original regression with blocking Change-Id: Iafe68108c821313a624dde4a8499b5f2f7f10a89 Reviewed-on: https://chromium-review.googlesource.com/332861 Commit-Ready: Chris Sosa <sosa@chromium.org> Tested-by: Chris Sosa <sosa@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/config_lib.py [modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/builders/simple_builders_unittest.py [modify] https://crrev.com/5851d2018a268db6ec8450abd453f59d773f8e12/cbuildbot/builders/simple_builders.py
,
Mar 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/875f88b99540469ed9ed49472750141a2dc27fbb commit 875f88b99540469ed9ed49472750141a2dc27fbb Author: Chris Sosa <sosa@chromium.org> Date: Sat Mar 12 02:11:50 2016 Fix mis-use of blocking in all configs. Blocking needlessly serializes HWTest runs. Looks like many developers used blocking when they meant critical (which is another bag of worms). All suites should run in parallel unless calling them should actually block others from running. This should speed up many test runs when we have more devices in a pool than we might need. BUG= chromium:594315 TEST=Unittests/visual so far. PSA and I talked with all test suite owners who set blocking=True to get their consent. Change-Id: I6230f7d6e285046f68dc66210ce543bb5851ed0a Reviewed-on: https://chromium-review.googlesource.com/332217 Commit-Ready: Chris Sosa <sosa@chromium.org> Tested-by: Chris Sosa <sosa@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Simran Basi <sbasi@chromium.org> [modify] https://crrev.com/875f88b99540469ed9ed49472750141a2dc27fbb/cbuildbot/config_dump.json [modify] https://crrev.com/875f88b99540469ed9ed49472750141a2dc27fbb/cbuildbot/chromeos_config.py
,
Apr 26 2016
,
Jun 1 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2016