Several layout tests under imported/csswg-test/vendor-imports/mozilla are flaky on the WebKit Linux Leak bot |
|||||||||||
Issue descriptionThe following tests are heavily flaky on the "WebKit Linux Leak" bot. Example build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/18059 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001a.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-002.xhtml imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-15.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-16.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-17.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-18.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-001.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001.html It seems this has been happening for a long time: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=imported%2Fcsswg-test%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fvariables%2Fvariable-declaration-1 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=imported%2Fcsswg-test%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-baseline Adding kojii@ and cbiesinger@ from issues 582836 and 553838 , where these tests were added. Can you please take a look and update the expectations if necessary?
,
Mar 14 2016
,
Mar 14 2016
,
Mar 14 2016
Issue 594603 has been merged into this issue.
,
Mar 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f8c02a65250bae6b6c1f156d5e031c89336eb37 commit 0f8c02a65250bae6b6c1f156d5e031c89336eb37 Author: csharp <csharp@chromium.org> Date: Mon Mar 14 18:37:01 2016 Mark some flexbox tests as leaky on Linux TBR=cbiesinger@chromium.org BUG= 594603 , 594309 Review URL: https://codereview.chromium.org/1789303009 Cr-Commit-Position: refs/heads/master@{#381022} [modify] https://crrev.com/0f8c02a65250bae6b6c1f156d5e031c89336eb37/third_party/WebKit/LayoutTests/LeakExpectations
,
Mar 15 2016
Talked with ksakamoto@ but he doesn't have idea either. Adding CSS variables people, but it looks like this is not related with specific features.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93edc00ba647814fd9b6157b37a96410ec2964d1 commit 93edc00ba647814fd9b6157b37a96410ec2964d1 Author: kojii <kojii@chromium.org> Date: Tue Mar 15 07:37:00 2016 Mark some CSS variables tests imported from mozilla as leaky on Linux BUG= 594309 Review URL: https://codereview.chromium.org/1801943004 Cr-Commit-Position: refs/heads/master@{#381191} [modify] https://crrev.com/93edc00ba647814fd9b6157b37a96410ec2964d1/third_party/WebKit/LayoutTests/LeakExpectations
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66ed2523a395c63121689114bea79759bec051e5 commit 66ed2523a395c63121689114bea79759bec051e5 Author: tapted <tapted@chromium.org> Date: Thu May 12 04:46:13 2016 Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on WebKit Linux Leak failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]})) since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19266 BUG= 610938 , 594309 NOTRY=true TBR=kojii@chromium.org Review-Url: https://codereview.chromium.org/1969713002 Cr-Commit-Position: refs/heads/master@{#393186} [modify] https://crrev.com/66ed2523a395c63121689114bea79759bec051e5/third_party/WebKit/LayoutTests/LeakExpectations
,
May 18 2016
,
May 18 2016
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead. Merging these to component:Blink for the Blink rotation to pick up and re-triage as appropriate.
,
May 24 2016
per comment 1 this seems webfont related in some way. putting into CSS for now becuase webfonts didn't want it (comment 6)
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/183615d125816b996710f8aa282c42bdeb73168e commit 183615d125816b996710f8aa282c42bdeb73168e Author: horo <horo@chromium.org> Date: Fri Jul 01 04:33:57 2016 Add text-combine-upright-compression-007.html into TestExpectations and LeakExpectations BUG= 594309 , 553838 TBR=cbiesinger Review-Url: https://codereview.chromium.org/2115773002 Cr-Commit-Position: refs/heads/master@{#403409} [modify] https://crrev.com/183615d125816b996710f8aa282c42bdeb73168e/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/183615d125816b996710f8aa282c42bdeb73168e/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 4 2016
lexbox-baseline-align-self-baseline-vert-001.html marked Leak on Linux in r381022 sometimes unexpectedly passes and litters Sheriff-o-Matic with confusing problems. e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1442/steps/webkit_tests/logs/stdio 22:09:05.648 13581 [14/27] imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-001.html passed unexpectedly 22:09:05.648 18513 worker/7 imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-001.html passed Regressions: Unexpected image-only failures (1) imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-001.html [ Failure Pass ] It doesn't appear in the buildbot build summary [1] - only stdio - but Sheriff-o-Matic still logs it. [1] https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1442
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36b09ebe2953a6d1a1c578e7f48aa3582299eb57 commit 36b09ebe2953a6d1a1c578e7f48aa3582299eb57 Author: tapted <tapted@chromium.org> Date: Fri Nov 04 06:28:14 2016 flexbox-baseline-align-self-baseline-vert-001.html sometimes unexpectedly passes on Webkit Linux Leak. Sadly it does, also, still leak sometimes. Mark it [ Failure Pass Leak ]. Also update some others to link to the duped-into issue. BUG= 594309 TBR=kojii@chromium.org Review-Url: https://codereview.chromium.org/2476873003 Cr-Commit-Position: refs/heads/master@{#429812} [modify] https://crrev.com/36b09ebe2953a6d1a1c578e7f48aa3582299eb57/third_party/WebKit/LayoutTests/LeakExpectations
,
Feb 13 2017
,
Mar 27 2017
If this is important enough for weekly updates, it's important enough to have an assigned owner. tapted: This is quite an old bug. Can you take another look at this issue and decide whether it can be closed, or determine what is the next step to be done? Thanks
,
Mar 27 2017
,
Apr 3 2017
,
Apr 3 2017
The csswg-test tests are currently disabled during the move to wpt/css (see issue 706118 ). After that I want to check the current status of each of these tests, but then I suspect this should be sharded into two bugs (for flexbox and for CSS variables) and potentially redirected away from Blink>CSS.
,
Apr 4 2017
Filed issue 708070 for the flexbox tests.
,
Apr 4 2017
And issue 582836 is the right place for the CSS variables failures, so I'll move my investigation over there.
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a1339aa58b7cb26f064fcb0f6d5d600390b50e8 commit 5a1339aa58b7cb26f064fcb0f6d5d600390b50e8 Author: hiroshige <hiroshige@chromium.org> Date: Tue May 30 09:22:32 2017 Remove Leak expectations for the tests not leaking recently on the bots ... based on the flakiness dashboard. BUG= 364398 , 301515 , 327574 , 629058 , 364417 , 506529 , 506754, 594309 Review-Url: https://codereview.chromium.org/2912553002 Cr-Commit-Position: refs/heads/master@{#475477} [modify] https://crrev.com/5a1339aa58b7cb26f064fcb0f6d5d600390b50e8/third_party/WebKit/LayoutTests/LeakExpectations
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/812d922bd835a38412a1f9464d7d5f6241a2e6f6 commit 812d922bd835a38412a1f9464d7d5f6241a2e6f6 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Jun 15 00:48:41 2017 Remove unexisting tests from LeakExpectations Bug: 733130 , 506754, 594309 Change-Id: Id11c5fa51b73d00656496df14209449a53525041 Reviewed-on: https://chromium-review.googlesource.com/535416 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#479562} [modify] https://crrev.com/812d922bd835a38412a1f9464d7d5f6241a2e6f6/third_party/WebKit/LayoutTests/LeakExpectations
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99a840cb5f9c861910136c60e0b4bbdab7800bb2 commit 99a840cb5f9c861910136c60e0b4bbdab7800bb2 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Jul 25 10:58:32 2017 Remove some tests that no longer leak from LeakExpectations It looks like some tests no longer cause leaking, they fail though. Bug: 594309 Change-Id: I87cfa3279e7ccd636ffa78dd7b751a275bc03714 Reviewed-on: https://chromium-review.googlesource.com/584549 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#489274} [modify] https://crrev.com/99a840cb5f9c861910136c60e0b4bbdab7800bb2/third_party/WebKit/LayoutTests/LeakExpectations |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kojii@chromium.org
, Mar 14 2016Owner: ksakamoto@chromium.org