New issue
Advanced search Search tips

Issue 594294 link

Starred by 1 user
Status: Fixed
Owner:
brucedaw...@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 440500



Sign in to add a comment

Mini_installer fails after upgrading to the latest wintoolchain

Project Member Reported by stanisc@chromium.org, Mar 12 2016 
What steps will reproduce the problem?
(1) Synced the latest source and ran gclient sync which installed wintoolchain
(2) Build mini_installer
(3) Run mini_installer on a test Windows 10 laptop

What is the expected output? What do you see instead?

Running mini_installer generates the following error:
The program can't start because VCRUNTIME140.dll is missing from your computer...

It appears this DLL is missing in the temporary directory where mini_installer unpacks setup files. Adding this DLL manually and rerunning the setup seems to work.

Comment 1 by stanisc@chromium.org, Mar 12 2016

Summary: Mini_installer fails after upgrading to the latest wintoolchain (was: Mini_installer fails to after upgrading to the latest wintoolchain)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4

commit 9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4
Author: brucedawson <brucedawson@chromium.org>
Date: Sat Mar 12 02:02:38 2016

Fix mini_installer to handle VS 2015 component builds

The mini_installer needs to unpack more CRT DLLs now that we are using
VS 2015. This change supports that, while still being VS 2013
compatible.

TBR=gab@chromium.org
BUG= 594294 

Review URL: https://codereview.chromium.org/1787883005

Cr-Commit-Position: refs/heads/master@{#380833}

[modify] https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4/chrome/tools/build/win/create_installer_archive.py

Comment 3 by brucedaw...@chromium.org, Mar 12 2016

Status: Fixed (was: Assigned)
Should be fixed now.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76311f1cf896615df4fa82b8421ae81cec9b7873

commit 76311f1cf896615df4fa82b8421ae81cec9b7873
Author: vmiura <vmiura@chromium.org>
Date: Sat Mar 12 04:35:38 2016

Revert of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1787883005/ )

Reason for revert:
Suspect this has caused Win32 builders to break.

BUG= 594322 

Original issue's description:
> Fix mini_installer to handle VS 2015 component builds
>
> The mini_installer needs to unpack more CRT DLLs now that we are using
> VS 2015. This change supports that, while still being VS 2013
> compatible.
>
> TBR=gab@chromium.org
> BUG= 594294 
>
> Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4
> Cr-Commit-Position: refs/heads/master@{#380833}

TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 594294 

Review URL: https://codereview.chromium.org/1791483004

Cr-Commit-Position: refs/heads/master@{#380838}

[modify] https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873/chrome/tools/build/win/create_installer_archive.py
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e59014501844be38d71617a7d218a242cc76574

commit 6e59014501844be38d71617a7d218a242cc76574
Author: brucedawson <brucedawson@chromium.org>
Date: Sat Mar 12 15:39:41 2016

Reland of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1791483004/ )

Reason for revert:
Suspect this was not the cause of Win32 builds breaking, and I don't
want developers hitting this mini_installer bug. If reverting again
please provide more details and a link to the breaks.

Original issue's description:
> Revert of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1787883005/ )
>
> Reason for revert:
> Suspect this has caused Win32 builders to break.
>
> BUG= 594322 
>
> Original issue's description:
> > Fix mini_installer to handle VS 2015 component builds
> >
> > The mini_installer needs to unpack more CRT DLLs now that we are using
> > VS 2015. This change supports that, while still being VS 2013
> > compatible.
> >
> > TBR=gab@chromium.org
> > BUG= 594294 
> >
> > Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4
> > Cr-Commit-Position: refs/heads/master@{#380833}
>
> TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 594294 
>
> Committed: https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873
> Cr-Commit-Position: refs/heads/master@{#380838}

TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 594322 

Review URL: https://codereview.chromium.org/1793753002

Cr-Commit-Position: refs/heads/master@{#380876}

[modify] https://crrev.com/6e59014501844be38d71617a7d218a242cc76574/chrome/tools/build/win/create_installer_archive.py
►

Sign in to add a comment