New issue
Advanced search Search tips

Issue 594278 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Unable to run views_unittests.

Project Member Reported by reillyg@chromium.org, Mar 11 2016 
I've built views_unittests with the following GN flags:

is_component_build = false                                                      
is_debug = false                                                                
use_goma = true                                                                 
target_os = "chromeos"                                                          
enable_nacl = true

and made sure that my system had the necessary packages installed with //build/install-build-deps.sh.

When I run views_unittests many tests fail with:

Xlib:  extension "RANDR" missing on display ":99".
[32464:32464:0311/151545:363472570540:ERROR:resource_bundle.cc(512)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570574:WARNING:resource_bundle.cc(407)] Unable to load image with id 5843
[32464:32464:0311/151545:363472570588:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570616:WARNING:resource_bundle.cc(407)] Unable to load image with id 5844
[32464:32464:0311/151545:363472570629:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570642:WARNING:resource_bundle.cc(407)] Unable to load image with id 5845
[32464:32464:0311/151545:363472570653:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570674:ERROR:resource_bundle.cc(512)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570687:WARNING:resource_bundle.cc(407)] Unable to load image with id 5942
[32464:32464:0311/151545:363472570699:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570712:WARNING:resource_bundle.cc(407)] Unable to load image with id 5943
[32464:32464:0311/151545:363472570731:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570743:WARNING:resource_bundle.cc(407)] Unable to load image with id 5944
[32464:32464:0311/151545:363472570755:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570772:ERROR:resource_bundle.cc(512)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570790:WARNING:resource_bundle.cc(407)] Unable to load image with id 5927
[32464:32464:0311/151545:363472570803:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570817:WARNING:resource_bundle.cc(407)] Unable to load image with id 5928
[32464:32464:0311/151545:363472570829:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570845:WARNING:resource_bundle.cc(407)] Unable to load image with id 5929
[32464:32464:0311/151545:363472570862:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570876:ERROR:resource_bundle.cc(512)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570889:WARNING:resource_bundle.cc(407)] Unable to load image with id 5959
[32464:32464:0311/151545:363472570901:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570914:WARNING:resource_bundle.cc(407)] Unable to load image with id 5960
[32464:32464:0311/151545:363472570930:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570943:WARNING:resource_bundle.cc(407)] Unable to load image with id 5961
[32464:32464:0311/151545:363472570956:ERROR:resource_bundle.cc(408)] NOTREACHED() hit.
[32464:32464:0311/151545:363472570996:FATAL:platform_font_linux.cc(90)] Check failed: FontList::ParseDescription(*default_font_description_, &query.families, &query.style, &query.pixel_size). Failed to parse font description 
#0 0x000000cac91e base::debug::StackTrace::StackTrace()
#1 0x000000cb4aaa logging::LogMessage::~LogMessage()
#2 0x000000ac61a1 gfx::PlatformFontLinux::PlatformFontLinux()
#3 0x000000ac6d16 gfx::PlatformFont::CreateDefault()
#4 0x000000ac00c9 gfx::Font::Font()
#5 0x000000ac105d gfx::FontList::GetDefaultImpl()
#6 0x000000ac0ef9 gfx::FontList::FontList()
#7 0x000000a30ee9 views::internal::NativeWidgetPrivate::GetWindowTitleFontList()
#8 0x000000a21a5d views::CustomFrameView::IconBounds()
#9 0x000000a229a8 views::CustomFrameView::LayoutTitleBar()
#10 0x000000a2297e views::CustomFrameView::Layout()
#11 0x000000a1427c views::View::SetBounds()
#12 0x000000a257c9 views::NonClientView::Layout()
#13 0x000000a106c2 views::FillLayout::Layout()
#14 0x000000a155f3 views::View::Layout()
#15 0x000000a1aa29 views::internal::RootView::Layout()
#16 0x000000a1ce72 views::Widget::Init()
#17 0x0000009c7814 views::test::TestInitialFocusWidgetDelegate::TestInitialFocusWidgetDelegate()
#18 0x0000006b4395 views::(anonymous namespace)::NativeWidgetAuraTest_PreventFocusOnNonActivableWindow_Test::TestBody()
#19 0x000000cf7287 testing::Test::Run()
#20 0x000000cf7f7a testing::TestInfo::Run()
#21 0x000000cf8403 testing::TestCase::Run()
#22 0x000000cff579 testing::internal::UnitTestImpl::RunAllTests()
#23 0x000000cff21e testing::UnitTest::Run()
#24 0x0000006b97b1 base::TestSuite::Run()
#25 0x0000006c4a74 base::LaunchUnitTests()
#26 0x0000005dc991 views::RunAllUnittests()
#27 0x0000005dcbc6 main
#28 0x7f07f484aec5 __libc_start_main
#29 0x00000045b029 <unknown>

I can find no additional documentation on the dependencies for these tests.

Comment 1 by reillyg@chromium.org, Mar 11 2016

Components: UI>GFX

Comment 2 by keta...@chromium.org, Mar 31 2016

Status: asi (was: Untriaged)

Comment 3 by reillyg@chromium.org, Mar 31 2016

Owner: keta...@chromium.org
Status: Assigned (was: asi)

Comment 4 by keta...@chromium.org, Mar 31 2016

Owner: marc...@chromium.org
Status: Assigned (was: asi)
assigning to Marcheu@ to triage and reassign as necessary.

Comment 5 by reillyg@chromium.org, Mar 31 2016

Owner: marc...@chromium.org

Comment 6 by marc...@chromium.org, Mar 31 2016

Owner: abodenha@chromium.org
hmm I'm not the right owner for this

Comment 7 by abodenha@chromium.org, Mar 31 2016

Components: -UI>GFX
Labels: -Pri-2 M-51 Pri-1
Owner: x...@chromium.org
xdai@ can you take a look?

Comment 8 by x...@chromium.org, Apr 1 2016 

Re reillyg@: I think you might have wrong GN build flags? I can repro the crash using the flags that you provided. But if I change the build flags [1] to:
is_component_build = true
is_debug = false
use_goma = true
target_os = "chromeos"
enable_nacl = false
Then everything works fine.

[1] https://www.chromium.org/developers/gn-build-configuration

Comment 9 by reillyg@chromium.org, Apr 1 2016 

The only differences are that is_component_build = true and enable_nacl = false. The tests should build both in the component build configuration and not. The presence of NaCl also shouldn't affect UI tests. Can you investigate further?

Comment 10 by x...@chromium.org, Apr 1 2016 

I think I made a mistake in #8. Somehow my gyp configuration was messed with gn configuration, which made me believe the views_unittests got passed using the build flags in #8. After I did a cleanup and rebuilt it from scratch, I found the flag values of is_component_build and enable_nacl have no effect at all. The views_unittests crashed under all circumstances.

I think the real problem is that we missing a dep that prevents the Resource from bundling. CL in review: https://codereview.chromium.org/1852883002/
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a17bef0d43cea3ff99446628379feb642adcd7f

commit 4a17bef0d43cea3ff99446628379feb642adcd7f
Author: xdai <xdai@chromium.org>
Date: Sat Apr 02 00:49:53 2016

Include the missing deps//ui/resources:ui_test_pak to make ResourceBundle work in views_unittests.

BUG= 594278 

Review URL: https://codereview.chromium.org/1852883002

Cr-Commit-Position: refs/heads/master@{#384761}

[modify] https://crrev.com/4a17bef0d43cea3ff99446628379feb642adcd7f/ui/views/BUILD.gn

Comment 12 by x...@chromium.org, Apr 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment