Update omnibox focus ring to be closer to native |
||||||||||||||||||
Issue description
,
Mar 17 2016
,
Mar 22 2016
,
Apr 28 2016
sgabriel@ - I was working on adding OS X-style focus ring animation (see attached movie) but learned that we don't want that? Also, I presume the spec you've attached supercedes the design in Issue 442929?
,
Apr 28 2016
My focus ring was here to mimic El Capitan's because we were building it custom before and I thought we would still be doing that. If we can get the native version, great! I think the video you attached looks good. Issue 442929 is WebUi, unrelated. This shouldn't impact core.
,
Apr 28 2016
,
Apr 28 2016
I'm not a fan for sure. Do we have options when using native ?
,
Apr 29 2016
I actually can't get native focus rings to work so I am implementing it myself. It looks pretty close to native. So, everything is possible as far as changing how it looks and behaves in Incognito.
,
Apr 29 2016
Oh got it. So my first spec had a #7BAAF7 stroke but I'm not super happy with the blue on incognito. Could you try a #FFF variant as shown attached? Also, what is the alpha value you use for the stroke ?
,
Apr 30 2016
Isn't #FFF so glaring, too? I think something more grayish would be better.
,
May 3 2016
We can adjust opacity based on actual implementation. See what feels right. I still want it to be prominent, the same way it is in normal.
,
May 6 2016
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c8dcd5c6248ac1b0434cbe4a247d0e45d1f4e20 commit 3c8dcd5c6248ac1b0434cbe4a247d0e45d1f4e20 Author: shrike <shrike@chromium.org> Date: Fri May 20 16:19:06 2016 [Mac][Material Design] Adjust Omnibox focus ring color for Incognito mode. Add sgabriel@'s Omnibox focus ring color for MD Incognito. R=avi@chromium.org BUG=594276 Review-Url: https://codereview.chromium.org/1990413003 Cr-Commit-Position: refs/heads/master@{#395090} [modify] https://crrev.com/3c8dcd5c6248ac1b0434cbe4a247d0e45d1f4e20/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 15 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16 2016
,
Mar 17 2017
Any update on this? Material Design completely implemented for ChromeOS, Windows and Linux. However, implementation for Mac is quite incomplete, yet there is no change for months. Inconsistency between platforms is very annoying, inconsistency Chrome for Mac itself is even worse. Although top of the Chrome is Material Design (it is not excellent, no fade in/fade out for buttons, no native search bar stroke like Safari, bookmarks misaligned etc.), download bar is old style. Chrome is very good browser, but the last design change is incomplete. Please take a look into this.
,
Jun 29 2017
The last piece on this bug (a nice to have) is to implement the Mac-style focus ring animation.
,
Jun 29 2017
shrike@, do you remember what the problem was with using a native focus ring?
,
Jun 29 2017
I don't. We went down the path of drawing our own focus ring (don't know if that's because the field editor is significantly smaller than the textfield). If we can use a native focus ring, that would be ideal.
,
Jun 29 2017
[Assigning to sdy@ for Q3; please don't start on this until downloads bar is near completion.]
,
Nov 22 2017
Hi All, is this fixed with https://chromium-review.googlesource.com/773718 ?
,
Nov 22 2017
Ooh interesting. I wasn't trying to fix this in r773718 -- I was just changing it so that the size would not be altered when it got focus. But that's a prerequisite for the changes wanted here. Also, the drawing code tweaks to the focus ring will make implementing this version much easier. Although I think to make progress on this, we need a spec for how to draw focus in popup windows. See the bottom part of the following gifs (from Issue 761701 ): non-retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312541&inline=1 retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312539&inline=1 I'm going to link up Issue 787893 as well. In Incognito the focus ring is always blue, even with the 'Graphite' OS theme. There's some discussion above about making it gray always (even with the 'Aqua' theme). Issue 787893 is about following the theme.
,
Dec 7 2017
Issue 787893 has been merged into this issue.
,
Jan 6 2018
Hey sdy@. Thank you. Looks nice. I noticed that the spec from comment 0 says that the blue focus ring incl. the grey Omnibox border is in total 3pt. In your screenshot it looks like that the blue focus ring incl. the grey Omnibox Border is in total 4pt. I modified the lower part of your screenshot with the lower part of the spec to demonstrate the difference. (Please see screenshot sdy@_vs_spec.) Reducing it to 3pt would be also good to not to be so close to the toolbar border when the Omnibox has focus. (Please see screenshot toobar_border_4pt_3pt.) What do you think?
,
Jan 8 2018
Hey mehmet@, I agree that it looks too big. We don't have control over the width of the native focus ring, only its position. The best option might be to inset it so that it starts slightly inside the text field. This is actually consistent with what search fields do in macOS, (screenshots attached). What do you think?
,
Jan 8 2018
Hi sdy@, thanks for the update - it also looks good and more native now. But I think I like your first suggestion from Friday more, because it looks much cleaner - especially at the corners inside the Omnibox. Let's wait what the Designers say and want :-)
,
Jan 9 2018
Hi Sidney, Thank you for providing me two builds with a "No inset" and an "Inset" version. Here is a short feedback: - With "No inset" it is looking really too bold :-( So I think this is not a good choice. - With "Inset" it is very close looking to the current focus ring and as you said to the focus rings in the rest of macOS. Therefore it would be really great if you could go on with this solution :-) - In Incognito window it is looking fine. - Changing the OS-appearance to graphite is also looking fine. - The native focus animation when you focus the Omnibox is also a really nice native effect :-) Looking forward to see the "Inset" version in Canary soon so that others can test it too :-) If screenshots are needed, please let me know. Thanks Mehmet
,
Mar 19 2018
,
May 1 2018
Any updates on this one as part of Material Refresh?
,
Jul 25
I'm releasing this bug because the Cocoa fixes I was working on are no longer relevant with MacViews. I'll leave it available and we should revisit it after M70 or so. For posterity, here's the change I started in Cocoa: https://chromium-review.googlesource.com/c/chromium/src/+/1150421
,
Dec 15
Any plans to implement this? |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Mar 17 2016