New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

add proguard definitions to prevent stripping methods

Project Member Reported by sgu...@chromium.org, Mar 11 2016

Issue description


Newly added WebviewChromium methods getHandler and findFocus
were being stripped by proguard. Explicitly keep them in .jar.
 

Comment 1 by sgu...@chromium.org, Mar 11 2016

Labels: OS-Android

Comment 2 by sgu...@chromium.org, Mar 11 2016

Add proguard definitions to prevent stripping of methods

Newly added WebviewChromium methods getHandler and findFocus
were being stripped by proguard. Explicitly keep them in .jar.

Committed: https://crrev.com/4e0e6528676be9ee35c31286c19f7bb9d4c7e957
Cr-Commit-Position: refs/heads/master@{#379922}
  

Comment 3 by sgu...@chromium.org, Mar 11 2016

Labels: Merge-Request-50

Comment 4 by amin...@google.com, Mar 11 2016

Labels: -Merge-Request-50 Merge-Approved-50
Merge approved for M50 branch 2661.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a016c402bcc923349a3c840bcb196bcfc1425d

commit c8a016c402bcc923349a3c840bcb196bcfc1425d
Author: Selim Gurun <sgurun@google.com>
Date: Sat Mar 12 00:40:55 2016

Add proguard definitions to prevent stripping of methods

Newly added WebviewChromium methods getHandler and findFocus
were being stripped by proguard. Explicitly keep them in .jar.

Review URL: https://codereview.chromium.org/1765333002

Cr-Commit-Position: refs/heads/master@{#379922}
(cherry picked from commit 4e0e6528676be9ee35c31286c19f7bb9d4c7e957)

BUG= 594274 

Review URL: https://codereview.chromium.org/1787733004 .

Cr-Commit-Position: refs/branch-heads/2661@{#201}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/c8a016c402bcc923349a3c840bcb196bcfc1425d/android_webview/apk/java/proguard.flags

Comment 6 by sgu...@chromium.org, Mar 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment