New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594268 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

68.1%-81.8% regression in blink_perf.layout at 380417:380451

Project Member Reported by qyears...@chromium.org, Mar 11 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=594268

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggL3zrgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggKjHogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggJa8vAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggO-luwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA___noAoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
Cc: rsch...@chromium.org
Components: Blink>Fonts
Owner: kojii@chromium.org
This is 5129404af72b720b8074a7277e088b001bd3c9e7. One of the tests is character fallback, and the other regresses on a site with Chinese characters (mydiyclub.com).

kojii, can you please investigate and/or revert?
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8667717dada38aae323b355a493b71f2ee322d32

commit 8667717dada38aae323b355a493b71f2ee322d32
Author: kojii <kojii@chromium.org>
Date: Sun Mar 27 18:37:14 2016

Revert of Modernize Chinese system font fallback list for Windows (patchset #3 id:40001 of https://codereview.chromium.org/1754143002/ )

Reason for revert:
Reverting due to a performance regressions.

BUG= 594268 

Original issue's description:
> Modernize Chinese system font fallback list for Windows
>
> Following the change for Japanese in crrev.com/379189, this patch
> changes Chinese system font fallback list for Windows to prefer more
> modern, post-ClearType era fonts. This change improves font rendering
> of generic font families and system fallback on Windows for Chinese
> characters, both simplified and traditional.
>
> Results of Win10 failures where this change affects are reviewed. All
> these failures on Win10 are due to changes in fonts and rebaseline
> should fix them. Their failure expectations are removed in this patch.
>
> BUG= 579842 ,  587072 
>
> Committed: https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7
> Cr-Commit-Position: refs/heads/master@{#380435}

TBR=eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 579842 ,  587072 

Review URL: https://codereview.chromium.org/1839593002

Cr-Commit-Position: refs/heads/master@{#383469}

[modify] https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp

Comment 5 by kojii@chromium.org, Mar 27 2016

Status: Fixed (was: Assigned)
Thank you for the report. Reverted.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65

commit 66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Mar 28 23:03:24 2016

Auto-rebaseline for r383469

https://chromium.googlesource.com/chromium/src/+/8667717da

BUG= 594268 
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1836113003 .

Cr-Commit-Position: refs/heads/master@{#383592}

[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/css/line-height-determined-by-primary-font-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/forms/month/month-appearance-l10n-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/international/lang-glyph-cache-separation-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/international/lang-glyph-cache-separation-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/international/plane2-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/international/plane2-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/justify-ideograph-complex-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/justify-ideograph-complex-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/justify-ideograph-simple-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/text/justify-ideograph-simple-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/fallback-orientation-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/fallback-orientation-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-baseline-alignment-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-font-fallback-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-01-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-04-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/verticalText-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-fonts-01-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-fonts-01-t-expected.txt
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/css/line-height-determined-by-primary-font-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/forms/month/month-appearance-l10n-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/lang-glyph-cache-separation-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/lang-glyph-cache-separation-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/plane2-expected.png
[delete] https://crrev.com/64dc0c77cc6d545c440e928ba0326a6de0505390/third_party/WebKit/LayoutTests/platform/win7/fast/text/justify-ideograph-complex-expected.png
[delete] https://crrev.com/64dc0c77cc6d545c440e928ba0326a6de0505390/third_party/WebKit/LayoutTests/platform/win7/fast/text/justify-ideograph-simple-expected.png
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/writing-mode/fallback-orientation-expected.png
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/writing-mode/vertical-align-table-baseline-expected.png
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/writing-mode/vertical-baseline-alignment-expected.png
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/fast/writing-mode/vertical-font-fallback-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/text-align-08-b-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/text-intro-01-t-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/text-intro-03-b-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/text-intro-04-t-expected.png
[add] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/batik/text/verticalText-expected.png
[modify] https://crrev.com/66d6be5dd470a06dfdd5a7c3259f4cce9b34ae65/third_party/WebKit/LayoutTests/platform/win7/svg/text/text-selection-fonts-01-t-expected.png

Sign in to add a comment