New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594264 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocked on:
issue 596357



Sign in to add a comment

App launcher jitters during touchpad scroll

Project Member Reported by kathrelk...@chromium.org, Mar 11 2016

Issue description

49.0.2623.95, 7834.60.0 (OR 50.0.2661.20)

What steps will reproduce the problem?
(1) Open the app launcher to the pages of apps.
(2) Use two fingers on the touchpad to scroll (either horizontally or vertically) between pages.

What is the expected output? What do you see instead?

When touchpad scrolls are very short and fingers are immediately lifted, the app launcher will scroll between pages.  When there are no more pages in that direction, there is a quick, horizontal jerk of the apps launcher page.

When touchpad scrolls are NOT short, or fingers are left to rest on the touchpad after scrolling, the app launcher appears to go crazy.  The horizontal jerking happens continuously.  Occasionally, the apps launcher will scroll a page in the other direction, then back again - all without moving your fingers

This problem reproduces very easily.

Touchscreen and mouse scrolls do not have this behavior.
 

Comment 1 by mgiuca@chromium.org, Mar 15 2016

Labels: -Type-Bug Needs-Bisect M-49 M-50 OS-Chrome Type-Bug-Regression
Owner: mgiuca@chromium.org
Status: Assigned (was: Untriaged)
Summary: App launcher hard to touchpad scroll / jitters during scroll (was: App launcher hard to touchpad scroll)
Please specify the operating system and (if Chrome OS, which I'm assuming it is) the device.

Seems like the same issue I reported in  Issue 594840 .
Yes, this is Chrome OS and these are the same bug
Cc: abodenha@chromium.org calamity@chromium.org mgiuca@chromium.org kuscher@chromium.org glevin@chromium.org
 Issue 594840  has been merged into this issue.
Cc: osh...@chromium.org
Labels: -Pri-2 ReleaseBlock-Stable Pri-1
This seems to be happening on higher resolution devices (I can repro on samus and lulu).

oshima@ could this be related to device scale changes?

Comment 5 by osh...@chromium.org, Mar 15 2016

It wasn't enabled on 49, so it's not related if it's really happening since 49. On 51, I'm seeing similar behavior even when I disable the device scale change.

Note that there was recent changes in scrolling, smooth scrolling and scrolling speed. (I think matt was involved in it?)
I'm getting touchscreen jitters on web page scrolling too. This looks like an issue with scroll handling rather than the app list.

Comment 7 by mgiuca@chromium.org, Mar 21 2016

This is a bit confusing because there seem to be separate issues for touchscreen and touchpad.

We can't repro any jittering issues for touchpad but we did find the app list was quite over-sensitive to touchpad gestures for scrolling. We might address that as low-priority.

The touch screen does jitter a lot though, but as Chris said, this affects all scroll surfaces, not jut app list, so I filed a new bug on input:  Issue 596357 .
mgiuca@ what are we tracking in this bug?

Comment 9 by mgiuca@chromium.org, Mar 22 2016

I'm not really sure. I think there are two issues: jittering on touch screen (covered by  Issue 596357 ) and hyper-sensitive touch pad (no bug filed yet). I think we should file a new bug for that and close this, but there is still the unreproducible original issue of jittery touch pad.

I'm on vacation now so I can't look at this. Calamity to triage.
Owner: calamity@chromium.org
Summary: App launcher jitters during touchpad scroll (was: App launcher hard to touchpad scroll / jitters during scroll)
I'm happy to keep this bug for the touchpad problem. I can reproduce the touchpad jittering.

This problem also appears on daisy devices suggesting it's not a problem with the Pixel's input event handling.
I'm happy to keep this bug for the touchpad problem. I can reproduce the touchpad jittering.

This problem also appears on daisy devices suggesting it's not a problem with the Pixel's input event handling. It may be that we just need to increase the threshold for the touch scrolling here.
calamity@ do you have a CL to fix the issue with the solution you suggested above?
I can't actually test the fix until I figure out how to reproduce the issue on a dev build. There's a constant that I could just change, but I don't know what a good number is without some trial and error.

Comment 15 by josa...@google.com, Mar 29 2016

Labels: -M-49
Fair. kathrelkeld@ can you please help repro on a dev build?
Confirmed with calamity@ that by dev build he means developer build, not dev mode build.  We don't use developer builds on my team, so he's on his own there.

He is finding someone else on his team to take this before he goes OOO
calamity@ does this still ring as a stable blocker for M50?
Labels: -ReleaseBlock-Stable
Nope. This has been around for a long time. The touchscreen issue was new, but that's in another bug now.
Cc: puneetster@chromium.org xiy...@chromium.org
 Issue 616133  has been merged into this issue.
Labels: -M-50 -Needs-Bisect M-53
calamity@ any thoughts here? This is still pretty chunky in 53.
Components: UI>Shell>Launcher
If you want a way to repro this, you can install a chromeos image from https://cros-goldeneye.corp.google.com/  I believe any of the latest images on your favorite device will repro the problem.
I need a repro on a debug build so I can see exactly what's happening with the events though. I can definitely repro on my stable Chromebook, it's just that I can't figure it out without a debug build to see what's happening with the scroll events.

I may be able to plug a touchpad into my machine but I'm not sure if the Linux ChromeOS will exhibit the same behavior...
Are you not able to access the goldeneye site?  There are test images there for your favorite devices that you should be able to install.  In the worst case you can do your own test build and install on a chromeos device.  Are you not able to do that for some reason?
#25 It needs to be a debug build that he can insert his own logging into. Theoretically you could build your own image onto a Chrome OS device but that's a lot of effort to go to. (We are not on the Chrome OS team so we don't do this thing normally.)
Did we resolve the need for machines / builds? Any help needed on this?
I have a speculative fix landing. It fixes the issue on a linux laptop we tried.
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4db974d7763416334efdbe4859427475ff5889f9

commit 4db974d7763416334efdbe4859427475ff5889f9
Author: calamity <calamity@chromium.org>
Date: Fri Jun 03 05:43:02 2016

Add scroll threshold for app list for mouse wheel events.

This CL fixes an issue with touchpad events being read as mousewheel
events and causing jank on touchpad scroll in the app list. Instead of
figuring out the whole stack and why the wrong event is coming in, just
use the scroll threshold everywhere.

BUG= 594264 

Review-Url: https://codereview.chromium.org/2029993002
Cr-Commit-Position: refs/heads/master@{#397642}

[modify] https://crrev.com/4db974d7763416334efdbe4859427475ff5889f9/ui/app_list/pagination_controller.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on  8477.0.0, 53.0.2768.0

Sign in to add a comment