crrev.com/1783313003 caused compile issues on WebKit Linux MSAN after v8 roll |
||
Issue descriptionhttps://codereview.chromium.org/1783313003 broke compile on WebKit Linux MSAN when the corresponding v8 roll went it: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8979 I reverted the v8 roll in https://codereview.chromium.org/1788763004/, and I'm filing this to make sure someone follows up on this. I've stopped the v8 rolls in the meantime. Output from failed bot: ... ../../v8/src/heap/heap.cc -o obj/v8/src/heap/v8_base.heap.o ../../v8/src/heap/heap.cc:1588:54: error: use of undeclared identifier 'size'; did you mean 'ConstantPoolEntry::size'? MSAN_MEMORY_IS_INITIALIZED(&entry->size_, sizeof(size)); ^~~~ ConstantPoolEntry::size ../../v8/src/msan.h:27:64: note: expanded from macro 'MSAN_MEMORY_IS_INITIALIZED' #define MSAN_MEMORY_IS_INITIALIZED(p, s) __msan_unpoison((p), (s)) ^ ../../v8/src/assembler.h:1222:14: note: 'ConstantPoolEntry::size' declared here static int size(Type type) { ^ ../../v8/src/heap/heap.cc:1588:53: error: invalid application of 'sizeof' to a function type MSAN_MEMORY_IS_INITIALIZED(&entry->size_, sizeof(size)); ^~~~~~ ../../v8/src/msan.h:27:64: note: expanded from macro 'MSAN_MEMORY_IS_INITIALIZED' #define MSAN_MEMORY_IS_INITIALIZED(p, s) __msan_unpoison((p), (s)) ^ ../../v8/src/heap/heap.cc:1589:53: error: use of undeclared identifier 'obj' MSAN_MEMORY_IS_INITIALIZED(&entry->obj_, sizeof(obj)); CC-ing v8 sheriffs and people from the culprit CL.
,
Mar 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/32a6e06acac80e11050c882e76c8344421566582 commit 32a6e06acac80e11050c882e76c8344421566582 Author: machenbach <machenbach@chromium.org> Date: Mon Mar 14 11:55:28 2016 V8: Update lkgr finder. Promote all currently stable tree closers into lkgr config. Remove too slow and basically redundant chromium builders. BUG= chromium:594262 Review URL: https://codereview.chromium.org/1799563002 [modify] https://crrev.com/32a6e06acac80e11050c882e76c8344421566582/infra/services/lkgr_finder/config/v8_cfg.pyl
,
Mar 14 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by machenb...@chromium.org
, Mar 12 2016Owner: machenb...@chromium.org