New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594261 link

Starred by 4 users
Status: Untriaged
Owner: ----
Cc:
█ bartfab@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove the configuration_policy build flag and ENABLE_CONFIGURATION_POLICY define

Project Member Reported by brettw@chromium.org, Mar 11 2016 
This flag doesn't work, isn't maintained, and accounts for a log of complexity in the build.

See:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/UCOhZfHN1sc

We should remove the build flag and corresponding feature define. The code in components should be key-ed off of iOS (the only place where we don't want policy). This is only a small amount of the code since most of it is in src/chrome that isn't used on iOS any more.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e6196bfe54114abdeb714f14c4d9ba66752849

commit 03e6196bfe54114abdeb714f14c4d9ba66752849
Author: brettw <brettw@chromium.org>
Date: Tue Mar 15 06:27:04 2016

Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

This feature is always enabled for non-iOS, and iOS doesn't use src/chrome any more. The build flag to disable the feature doesn't work because it is untested and unmtained.

This is a first step to removing other uses as well.

BUG=594261

Review URL: https://codereview.chromium.org/1786263002

Cr-Commit-Position: refs/heads/master@{#381185}

[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/android/signin/signin_manager_android.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/browser_process_platform_part_base.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/browser_process_platform_part_base.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/extensions/api/chrome_extensions_api_client.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/extensions/api/storage/settings_apitest.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/io_thread.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/policy/profile_policy_connector.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/policy/profile_policy_connector_factory.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/common/url_constants.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849/chrome/test/base/testing_profile.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db234c06ff6c308520594591fa54f80b08411888

commit db234c06ff6c308520594591fa54f80b08411888
Author: brettw <brettw@chromium.org>
Date: Tue Mar 22 18:19:39 2016

Remove configuration policy from chrome build files.

The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.

BUG=594261

Review URL: https://codereview.chromium.org/1798273002

Cr-Commit-Position: refs/heads/master@{#382614}

[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/android/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/android/chrome_apk.gyp
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/app/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/browser/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/browser/policy/BUILD.gn
[delete] https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865/chrome/browser/policy/profile_policy_connector_stub.cc
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome.gyp
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_browser.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_common.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_dll.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_exe.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_process_finder.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_tests.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/common/BUILD.gn
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/policy.gypi
[modify] https://crrev.com/db234c06ff6c308520594591fa54f80b08411888/chrome/test/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e742862f9555579e3239d9658766081ac4729e92

commit e742862f9555579e3239d9658766081ac4729e92
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 22 21:17:26 2016

Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ )

Reason for revert:
Speculative revert: could have caused the Win8 GN build failures. See  crbug.com/597032 

Original issue's description:
> Remove configuration policy from chrome build files.
>
> The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
>
> BUG=594261
>
> Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> Cr-Commit-Position: refs/heads/master@{#382614}

TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261

Review URL: https://codereview.chromium.org/1818423003

Cr-Commit-Position: refs/heads/master@{#382681}

[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/android/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/android/chrome_apk.gyp
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/app/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/browser/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/browser/policy/BUILD.gn
[add] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/browser/policy/profile_policy_connector_stub.cc
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome.gyp
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_browser.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_common.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_dll.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_exe.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_process_finder.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_tests.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/common/BUILD.gn
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/policy.gypi
[modify] https://crrev.com/e742862f9555579e3239d9658766081ac4729e92/chrome/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a3e25d653b7de06a9c9c90e589265a57e17076

commit e5a3e25d653b7de06a9c9c90e589265a57e17076
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 22 21:45:08 2016

Reland of move configuration policy from chrome build files. (patchset #1 id:1 of https://codereview.chromium.org/1818423003/ )

Reason for revert:
Reland original patch, it was not the cause

Original issue's description:
> Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ )
>
> Reason for revert:
> Speculative revert: could have caused the Win8 GN build failures. See  crbug.com/597032 
>
> Original issue's description:
> > Remove configuration policy from chrome build files.
> >
> > The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
> >
> > BUG=594261
> >
> > Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> > Cr-Commit-Position: refs/heads/master@{#382614}
>
> TBR=atwilson@chromium.org,brettw@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594261
>
> Committed: https://crrev.com/e742862f9555579e3239d9658766081ac4729e92
> Cr-Commit-Position: refs/heads/master@{#382681}

TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261

Review URL: https://codereview.chromium.org/1825603003

Cr-Commit-Position: refs/heads/master@{#382689}

[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/android/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/android/chrome_apk.gyp
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/app/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/browser/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/browser/policy/BUILD.gn
[delete] https://crrev.com/340545a9d2c2bf94d93421bbb6bfa40596ae4523/chrome/browser/policy/profile_policy_connector_stub.cc
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome.gyp
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_browser.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_common.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_dll.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_exe.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_process_finder.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_tests.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/common/BUILD.gn
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/policy.gypi
[modify] https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076/chrome/test/BUILD.gn

Comment 5 by brettw@chromium.org, Aug 17 2016

Cc: brettw@chromium.org bartfab@chromium.org
 Issue 174904  has been merged into this issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 18 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment