New issue
Advanced search Search tips

Issue 594260 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mus needs test coverage of WidgetTest.WidgetDeleted_InOnMousePressed

Project Member Reported by sky@chromium.org, Mar 11 2016

Issue description

The test currently doesn't exercise the right thing for mus, so it's NOTIMPLEMENTED. We need a similar test for mus that exercises what the test is trying to do.
 
Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Pri-2 -Hotlist-Recharge-Cold -Proj-Mustash Proj-Mash-SingleProcess Pri-3
Status: Available (was: Untriaged)
Bug scrub: Related to issue 663809

Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73be1efe0bf2d08ee85c3a4c29a8e5a11e959600

commit 73be1efe0bf2d08ee85c3a4c29a8e5a11e959600
Author: Scott Violet <sky@chromium.org>
Date: Fri Sep 07 21:18:15 2018

views: fix WidgetTest.WidgetDeleted_InOnMousePressed for mus

This fix would actually apply to desktop views if the test created
DesktopNativeWidgetAura there as well.

This also removes a CHECK in event_generator_test that was added here:
https://codereview.chromium.org/147203004/diff/140001/ui/aura/test/event_generator.cc
and makes EventGenerator reset current_target_ if the dispatcher is destroyed.
This assumes either the target is reset, or the generator destroyed.

BUG= 594260 
TEST=test only changes

Change-Id: I860f7e254a0d9a5826955011b74da8e25d50f042
Reviewed-on: https://chromium-review.googlesource.com/1213374
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589659}
[modify] https://crrev.com/73be1efe0bf2d08ee85c3a4c29a8e5a11e959600/ui/events/test/event_generator.cc
[modify] https://crrev.com/73be1efe0bf2d08ee85c3a4c29a8e5a11e959600/ui/views/widget/widget_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment