New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594243 link

Starred by 3 users
Status: Fixed
Owner:
█ bruthig@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ bruthig@chromium.org
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

MD ripple animation does not extend to button edges on truncated bookmarks bar buttons at 2x device scale factor

Project Member Reported by tdander...@chromium.org, Mar 11 2016 
Bug present in M-50, observed on ChromeOS.

To reproduce:
1. Make sure MD in the browser's top chrome is enabled (--top-chrome-md is set to material or material-hybrid in about:flags).
2. Show the bookmarks bar.
3. Add a page with a long title to the bookmarks bar so that the end of the label is truncated.
4. Click or tap on the button.

What happens:
The material design ripple does not extend to the right-hand side of the button.

What should happen instead:
The ripple should extend to both sides of the button.

Comment 1 by bruthig@chromium.org, Mar 15 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce72fa9b7010a4c72b9363469087444ec4f77792

commit ce72fa9b7010a4c72b9363469087444ec4f77792
Author: bruthig <bruthig@chromium.org>
Date: Tue Mar 15 16:38:31 2016

Increased Canvas size for the CircleLayerDelegate that is used for MD ripples.

The Bookmark ripple was getting clipped on devices with a 2x scale
factor due to the Canvas not being large enough.

BUG= 594243 

TEST=manual

Review URL: https://codereview.chromium.org/1806563002

Cr-Commit-Position: refs/heads/master@{#381232}

[modify] https://crrev.com/ce72fa9b7010a4c72b9363469087444ec4f77792/ui/views/animation/ink_drop_painted_layer_delegates.cc

Comment 4 by bruthig@chromium.org, Mar 15 2016

Status: Fixed (was: Started)

Comment 5 by bruthig@chromium.org, Mar 21 2016

Labels: Merge-Request-50

Comment 6 by tin...@google.com, Mar 21 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb7744700843d05e454194457279d77c0e9f2572

commit fb7744700843d05e454194457279d77c0e9f2572
Author: Ben Ruthig <bruthig@chromium.org>
Date: Mon Mar 21 17:35:27 2016

Increased Canvas size for the CircleLayerDelegate that is used for MD ripples.

The Bookmark ripple was getting clipped on devices with a 2x scale
factor due to the Canvas not being large enough.

BUG= 594243 

TEST=manual

Review URL: https://codereview.chromium.org/1806563002

Cr-Commit-Position: refs/heads/master@{#381232}
(cherry picked from commit ce72fa9b7010a4c72b9363469087444ec4f77792)

Review URL: https://codereview.chromium.org/1820913003 .

Cr-Commit-Position: refs/branch-heads/2661@{#311}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/fb7744700843d05e454194457279d77c0e9f2572/ui/views/animation/ink_drop_painted_layer_delegates.cc

Comment 8 by ajha@chromium.org, Mar 22 2016

Labels: TE-Verified-M50 TE-Verified-50.0.2661.48
Verified the merge on the latest M-50(50.0.2661.48) on Linux Ubuntu 14.04 @ scale factor of 2. This is working as intended. Attached is the screen-shot of the same.
594243_ScaleFactor2.png
136 KB View Download

Comment 9 by bruthig@chromium.org, Mar 22 2016

Cc: bruthig@chromium.org tdander...@chromium.org
 Issue 596769  has been merged into this issue.
►

Sign in to add a comment