We have at least 3 versions of the code: WebInputEventTraits::GetName PageWidgetEventHandler::inputTypeToName TestPlugin::handleInputEvent A static method in WebInputEvent makes the most sense to me.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df93225cc0d68727634f91d40e17a9cbe881aa1c commit df93225cc0d68727634f91d40e17a9cbe881aa1c Author: sahel <sahel@chromium.org> Date: Thu Aug 25 23:20:45 2016 Type->String helper function added to WebInputEvent. WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned up. The helper function is called in TestPlugin::handleInputEvent instead of re-implementation of the Type->String. No test is written for this cl. BUG= 594223 Review-Url: https://codereview.chromium.org/2250233002 Cr-Commit-Position: refs/heads/master@{#414580} [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/components/test_runner/test_plugin.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/input/gesture_event_queue.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/input/synthetic_gesture_target_base.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/input/touch_emulator_unittest.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/common/input/gesture_event_stream_validator.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/common/input/touch_event_stream_validator.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/renderer/input/input_handler_manager.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/content/renderer/input/render_widget_input_handler.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/Source/web/PageWidgetDelegate.cpp [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/Source/web/PageWidgetDelegate.h [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/Source/web/WebInputEvent.cpp [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/third_party/WebKit/public/platform/WebInputEvent.h [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/ui/events/blink/BUILD.gn [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c/ui/events/blink/web_input_event_traits.h
Comment 1 by mustaq@chromium.org
, Aug 15 2016