Virtual layout tests should inherit SLOW expectations from their non-virtual counterparts. |
|||||||||||||
Issue descriptionIn https://crbug.com/594189 , I discovered that the test virtual/spv2/fast/overflow/lots-of-sibling-inline-boxes.html was frequently timing out, even though its non-virtual counterpart, fast/overflow/lots-of-sibling-inline-boxes.html has the SLOW expectation. lukasza@ and I were surprised to find that SLOW wasn't being inherited here, even though it seems like it should be. There are similarly duplicated expectations for other tests as well: crbug.com/420008 inspector/tracing/ [ Slow ] crbug.com/420008 virtual/threaded/inspector/tracing/ [ Slow ] phajdan.jr@, dpranke@, jochen@: any thoughts on whether this might be worth fixing?
,
Mar 11 2016
,
Mar 11 2016
Having virtual tests inherit the slowness of the non virtual test suite seems reasonable to me. It's a bit magic, but it's what you want 99% of the time and the consequences of marking too many things as Slow isn't that bad for the remaining 1%. Naina recently added lint checks that you can only use Slow to the SlowTests file and can't put anything other than Slow in the SlowTests file. The files actually merge their expectations. So, I think the related problem Dirk pointed out is not actually a problem, right?
,
Mar 11 2016
Long ago when I was working on this code, if a file had a specific expectations line, it would override *any* expectations on enclosing directories (and it had to). Unless we've specifically added code to *not* do that for Slow tests -- and I don't think we have based on what've seen over the past week -- I think it's still a problem.
,
Mar 11 2016
I don't think that's how it works if we're merging across files. I might be wrong though. I think if you have: SlowTests: foo [ Slow ] TestExpectations: foo/bar.html [ Failure ] Then foo/bar.html will get [ Slow Failure ].
,
Mar 11 2016
Hm. At first test, it looks like you're right, but now I'm puzzled by why I'm seeing so many inspector timeouts, then ...
,
Mar 18 2016
Fixing component name after Monorail migration
,
Mar 30 2016
,
Apr 18 2016
Blink>ToolsTest renamed to Blink>Infra
,
May 18 2016
,
May 18 2016
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
,
Jun 5 2016
,
Aug 13 2016
,
Dec 2 2016
Hmmm... Alex found out that lack of inheritance appears to be by design according to https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_tests.md I am still not sure if I agree with this design...
,
Dec 2 2016
FWIW, the problem of lack of inheritance can be seen in https://crrev.com/2505933002 and in https://crrev.com/2547733002
,
Dec 2 2016
Yes. Feel free to change the implementation if you find that we reduce the total number of expectations by doing so. I don't think it's clear a priori which is better.
,
Mar 7 2017
,
Sep 6 2017
,
Jan 2 2018
This is a P2 but hasn't seen any activity in over a year. Is it really a P2, and if so should someone be assigned? FWIW, seems like a P3 to me.
,
Jan 2 2018
P3 is fine.
,
Mar 26 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dpranke@chromium.org
, Mar 11 2016Components: Blink>Tools>Test
Labels: b
Status: Available (was: Untriaged)