CanvasCaptureHandlerTest.VerifyOpaqueFrame fails under Valgrind |
|||
Issue descriptionThis test has been failing for a day or so on the Linux and Chrome OS Valgrind bots: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/48063 https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/37415 [ RUN ] CanvasCaptureHandlerTest.VerifyOpaqueFrame/0 ../../content/renderer/media/canvas_capture_handler_unittest.cc:104: Failure Value of: (estimated_capture_time - base::TimeTicks()).InMilliseconds() Actual: 2064167 Expected: video_frame->timestamp().InMilliseconds() Which is: 2064166 [ FAILED ] CanvasCaptureHandlerTest.VerifyOpaqueFrame/0, where GetParam() = false (133 ms) [ RUN ] CanvasCaptureHandlerTest.VerifyOpaqueFrame/1 ../../content/renderer/media/canvas_capture_handler_unittest.cc:104: Failure Value of: (estimated_capture_time - base::TimeTicks()).InMilliseconds() Actual: 2064294 Expected: video_frame->timestamp().InMilliseconds() Which is: 2064293 [ FAILED ] CanvasCaptureHandlerTest.VerifyOpaqueFrame/1, where GetParam() = true (71 ms)
,
Mar 11 2016
Thanks. I've cancelled my commit disabling this test.
,
Mar 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43b0892d86eb8121861d41056d573b495ef518f3 commit 43b0892d86eb8121861d41056d573b495ef518f3 Author: emircan <emircan@chromium.org> Date: Sat Mar 12 00:55:36 2016 Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/37386 BUG= 594200 Review URL: https://codereview.chromium.org/1782193003 Cr-Commit-Position: refs/heads/master@{#380809} [modify] https://crrev.com/43b0892d86eb8121861d41056d573b495ef518f3/content/renderer/media/canvas_capture_handler.cc
,
Mar 12 2016
,
May 24 2016
Renamed Blink>MediaCaptureFromElement to Blink>MediaStream>CaptureFromElement. Moving issues to the new component. |
|||
►
Sign in to add a comment |
|||
Comment 1 by emir...@chromium.org
, Mar 11 2016