New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594194 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Add UMA for Physical Web launch state

Project Member Reported by mmo...@chromium.org, Mar 11 2016

Issue description

OS: Android

It would be nice if we knew if PW is enabled, and if not, why not.

iOS tracks:
- NEVEROPTED vs OPTIN vs OPTOUT
- DISABLED vs ENABLED
- BTOFF vs BTON
- LOCK vs UNLOCK

I'm not sure what the last is.  Android additionally has Location enabled/disabled.
 

Comment 2 by mmo...@chromium.org, Mar 11 2016

Wow, thanks Ani I didn't realize we had these.  Maybe we don't need this bug request?  Perhaps we can auto-generated with a clever dremel query?
AFAIK, we can'd do some of these splits through dremel alone (BTON vs. OFF, Location ON vs. OFF), so it might still be worth having

Comment 4 by cco3@chromium.org, Mar 18 2016

Cc: mmo...@chromium.org

Comment 5 by mmo...@chromium.org, Mar 29 2016

Conley, I saw a patch added that tracked startup launch state, thanks!

Do you know if it will be possible to match up the other metrics to the launch state?  E.g. map the latency, # beacons found, etc metrics to the launch state, as part of a "transaction"?

Specifically, I'd like to isolate UMA numbers for # beacons found for onboarding vs notification vs non-notification (button, recents, ...) launch events, to help identify anomalies in #beacons on startup.

Wondering if the latest change helps this?
Labels: M-52
Today we have a slightly undesirable effect that opening Chrome icon sometimes opens PW Activity:

1. Tap PW Notification
2. Go Home
3. Tap Chrome icon (make sure its same version as from 1.)

I expect that often times this happens when there are no beacons nearby, and may be the source of some of our 0-results UMA.

It would be nice if we can somehow identify this case specifically.  I am not sure if there is a signal we can use to differentiate this vs using Recents switcher vs using "See what's nearby"?
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b

commit 10cbc3ad60388fc48ebfbbd16c8d3db9872c009b
Author: cco3 <cco3@chromium.org>
Date: Fri Apr 08 21:56:59 2016

Record UMA for Physical Web state

The "Physical Web state" refers to:
* Data connection
* BT permission/enablement
* Location permission/provider

We record this state:
* At chrome startup
* When launching the ListUrlsActivity from the diagnostics page
* When launching the ListUrlsActivity from the preferences page

BUG= 594194 

Review URL: https://codereview.chromium.org/1814213004

Cr-Commit-Position: refs/heads/master@{#386215}

[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[add] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/Utils.java
[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/chrome/android/java_sources.gni
[modify] https://crrev.com/10cbc3ad60388fc48ebfbbd16c8d3db9872c009b/tools/metrics/histograms/histograms.xml

Comment 9 by cco3@chromium.org, Apr 11 2016

Status: Fixed (was: Assigned)

Comment 10 by cco3@chromium.org, Apr 12 2016

Status: Started (was: Fixed)
We caused some memory issue.  I'll resubmit this piece by piece.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 13 2016

Comment 12 by cco3@chromium.org, Apr 15 2016

Trace file per yfriedman's request
uma.trace
368 KB Download
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd04070aa5257204200985a97148f7f8de4d508b

commit dd04070aa5257204200985a97148f7f8de4d508b
Author: cco3 <cco3@chromium.org>
Date: Sat Apr 16 01:48:10 2016

Simplify Physical Web hook in Chromium startup

This will allow us to do more on startup without having to put more
lines into both the DeferredStartupHandler and the PhysicalWeb
class.  Eventually, we may want to record some UMA stats on startup,
and this will allow us to do so easily.

BUG= 594194 

Review URL: https://codereview.chromium.org/1882333002

Cr-Commit-Position: refs/heads/master@{#387785}

[modify] https://crrev.com/dd04070aa5257204200985a97148f7f8de4d508b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/dd04070aa5257204200985a97148f7f8de4d508b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4766630a78c1e35ef85211da0829f54d85541df

commit f4766630a78c1e35ef85211da0829f54d85541df
Author: cco3 <cco3@chromium.org>
Date: Mon Apr 18 20:30:43 2016

Record UMA for Physical Web state on debug actions

The "Physical Web state" refers to:
* Data connection
* BT permission/enablement
* Location permission/provider

We record this state:
* When launching the ListUrlsActivity from the diagnostics page
* When launching the ListUrlsActivity from the preferences page

BUG= 594194 

Review URL: https://codereview.chromium.org/1887523002

Cr-Commit-Position: refs/heads/master@{#388001}

[modify] https://crrev.com/f4766630a78c1e35ef85211da0829f54d85541df/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

Comment 16 by cco3@chromium.org, May 26 2016

Status: Fixed (was: Started)

Sign in to add a comment