New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove kAutofillWalletSyncExperimentEnabled

Project Member Reported by jdonnelly@chromium.org, Mar 11 2016

Issue description

This sync experiment has been at 100% of all users for a while.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04c8fd5e7c57f75262f477e6ac94e18ca76b6371

commit 04c8fd5e7c57f75262f477e6ac94e18ca76b6371
Author: jdonnelly <jdonnelly@chromium.org>
Date: Tue Mar 15 20:43:22 2016

Remove kAutofillWalletSyncExperimentEnabled.

This sync experiment has been at 100% of all users for a while.

Also, add the autofill_wallet type to sync/tools/testserver/chromiumsync.py. Previously, AutofillWalletDataTypeController::IsEnabled was returning false in the test environment because the sync setting was false. Now that we enable by default, the sync integration tests are covering this type. Which I assume is a good thing.

BUG= 594182 

Review URL: https://codereview.chromium.org/1785923010

Cr-Commit-Position: refs/heads/master@{#381304}

[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/chrome/browser/autofill/android/personal_data_manager_android.cc
[delete] https://crrev.com/6b0615b5f2dd5744a9e606ec88a9062bca934d56/chrome/browser/autofill/options_util.cc
[delete] https://crrev.com/6b0615b5f2dd5744a9e606ec88a9062bca934d56/chrome/browser/autofill/options_util.h
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/chrome/chrome_browser.gypi
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill.gypi
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[delete] https://crrev.com/6b0615b5f2dd5744a9e606ec88a9062bca934d56/components/autofill/core/browser/options_util.cc
[delete] https://crrev.com/6b0615b5f2dd5744a9e606ec88a9062bca934d56/components/autofill/core/browser/options_util.h
[delete] https://crrev.com/6b0615b5f2dd5744a9e606ec88a9062bca934d56/components/autofill/core/browser/options_util_unittest.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/common/autofill_pref_names.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/autofill/core/common/autofill_pref_names.h
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/components/components_tests.gyp
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/sync/internal_api/public/util/experiments.h
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/sync/internal_api/sync_manager_impl.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/sync/protocol/experiments_specifics.proto
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/04c8fd5e7c57f75262f477e6ac94e18ca76b6371/sync/tools/testserver/chromiumsync.py

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment