New issue
Advanced search Search tips

Issue 594181 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

WindowTreeClientUnittest Regressions

Project Member Reported by jonr...@chromium.org, Mar 11 2016 
WindowTreeClientUnittest was landed in https://codereview.chromium.org/1771393002

However it was not added into the build config, so it has not been running on waterfall.

Since then some tests have begun failing.

This issue is to track reenabling the test, and subsequently fixing the regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d42f4d131bc79b940169ea4cc5153c61530634e

commit 3d42f4d131bc79b940169ea4cc5153c61530634e
Author: jonross <jonross@chromium.org>
Date: Fri Mar 11 21:04:44 2016

Reenable WindowTreeClientUnittests

Add WindowTreeClientUnittest to build config. Address compilation changes. Disable tests that are currently failing.

TEST=WindowTreeClientUnittest
BUG= 594181 

Review URL: https://codereview.chromium.org/1783413002

Cr-Commit-Position: refs/heads/master@{#380726}

[modify] https://crrev.com/3d42f4d131bc79b940169ea4cc5153c61530634e/components/mus/ws/BUILD.gn
[modify] https://crrev.com/3d42f4d131bc79b940169ea4cc5153c61530634e/components/mus/ws/window_tree_client_unittest.cc

Comment 2 by sky@chromium.org, Mar 14 2016

Labels: -Pri-2 Pri-1

Comment 3 by jonr...@chromium.org, Mar 15 2016

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569e3ef13ec1913cd59c196c94a28609a3959985

commit 569e3ef13ec1913cd59c196c94a28609a3959985
Author: jonross <jonross@chromium.org>
Date: Tue Mar 15 20:09:42 2016

Update DefaultAccessPolicy Hierarchy Notifications

Update ShouldNotifyOnHierarchyChange to not notify if the window was not created by that connection. Ignoring the existance of new/old parent.

Re-enable tests that were failing due to this.

TEST=WindowTreeClientTest
BUG= 594181 

Review URL: https://codereview.chromium.org/1805023003

Cr-Commit-Position: refs/heads/master@{#381297}

[modify] https://crrev.com/569e3ef13ec1913cd59c196c94a28609a3959985/components/mus/ws/default_access_policy.cc
[modify] https://crrev.com/569e3ef13ec1913cd59c196c94a28609a3959985/components/mus/ws/window_tree_client_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ff87daa6693938ff4750a612137cdaf089f705

commit 68ff87daa6693938ff4750a612137cdaf089f705
Author: jonross <jonross@chromium.org>
Date: Tue Mar 15 21:29:02 2016

Update WindowTreeClientTest.OnEmbeddedAppDisconnected

The exptectations of WindowTreeClientTest.OnEmbeddedAppDisconnected are no longer correct. With embed root removed, non owning connections should not be notified of disconnections.

This change updates the test to reflect the expected behaviour

TEST=WindowTreeClientTest.OnEmbeddedAppDisconnected
BUG= 594181 

Review URL: https://codereview.chromium.org/1797413002

Cr-Commit-Position: refs/heads/master@{#381318}

[modify] https://crrev.com/68ff87daa6693938ff4750a612137cdaf089f705/components/mus/ws/window_tree_client_unittest.cc

Comment 6 by jonr...@chromium.org, Mar 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment