New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594160 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

No warning on async addEventListener

Project Member Reported by jakearchibald@chromium.org, Mar 11 2016

Issue description

Don't know if this is a regression, or if it never worked, but original ticket is https://bugs.chromium.org/p/chromium/issues/detail?id=401870

https://rawgit.com/jakearchibald/e124e1ba586b87377be5/raw/eab602df08a7241a25f301dd824250d0c49d5ebe/index.html

The above adds a listener in a separate task, but no warning is shown.
 

Comment 1 by falken@chromium.org, Mar 14 2016

Status: Available (was: Untriaged)
Ah yes those warnings were only added for 'install' and 'activate' event handlers <https://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp?r1=184227&r2=184226&pathrev=184227>. I think at the time it matched the spec.
Cc: shimazu@chromium.org
 Issue 644617  has been merged into this issue.
Cc: horo@chromium.org
 Issue 644991  has been merged into this issue.
Components: Platform>DevTools
Labels: -Pri-2 Pri-1
Owner: eostroukhov@chromium.org
Status: Assigned (was: Available)
As I wrote in  Issue 644991 , warning messages might be eliminated by https://crrev.com/2297803002. Could you take a look this issue?

For repro, I created a simple test case: https://amiq11.github.io/sw-one-registration/register.html
Warning will be shown at the devtools' console using stable, but it won't using ToT.

Also I updated the priority to follow  Issue 644991 .
As for repro commented at https://crrev.com/2297803002, I guess you couldn't do it because of no-fetch optimization of the service worker. I added 'register' and 'unregister' button to https://amiq11.github.io/sw-one-registration/register.html for easier testing.

steps to repro:
1. open https://amiq11.github.io/sw-one-registration/register.html
2. open DevTools' console
3. click unregister button just in case
4. click register button
5. Using stable, you can see a warning "Event handler of 'install' event must be added on the initial evaluation of worker script." though you cannot when including the patch.

If you have something wrong, please let me know.
Thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e

commit bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e
Author: shimazu <shimazu@chromium.org>
Date: Thu Sep 15 06:35:45 2016

Revert "[DevTools] Make log agent optional."

This reverts commit d0125b8fc7acf574d14b7e0dad739d814c8593c5.

Reason:
Warnings from ServiceWorkerGlobalScope doesn't show up in devtools' console

BUG= 594160 
TBR=eostroukhov, pfeldman

Review-Url: https://codereview.chromium.org/2344813002
Cr-Commit-Position: refs/heads/master@{#418793}

[modify] https://crrev.com/bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/bdf22b26c6d9a10f2c8bfc956f59b6c482663d8e/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Comment 7 by falken@chromium.org, Sep 16 2016

Cc: -shimazu@chromium.org eostroukhov@chromium.org
Labels: -Pri-1 Pri-2
Owner: shimazu@chromium.org
Updating priority/owner as the revert landed. The remaining work is to add the warning to all events, not just install/activate.
Status: Fixed (was: Assigned)
Labels: M-55

Sign in to add a comment