New issue
Advanced search Search tips

Issue 594142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 589647



Sign in to add a comment

Figure out why BC_PDF417DetectionResultColumn takes a long time to compile with latest clang

Project Member Reported by thakis@chromium.org, Mar 11 2016

Issue description

The clang roll 261368:262839 https://codereview.chromium.org/1764413002 landed about the same time as enabling XFA (https://codereview.chromium.org/1775173002). With both changes in, BC_PDF417DetectionResultColumn.cpp takes a very long time to build, see bug 593891.

We should figure out if a recent clang change made building this TU slower, and revert that recent change upstream. (And possibly do a quick follow-up roll.)
 

Comment 1 by thakis@chromium.org, Mar 11 2016

r262516 good, r252816 bad

Comment 2 by thakis@chromium.org, Mar 11 2016

Stand-alone repro, build like so:

 ../../third_party/llvm-build/Release+Asserts/bin/clang++ -m64 -march=x86-64 -O2 -fno-exceptions -fno-rtti -std=gnu++11 -c foo.ii -o foo.o
foo.ii
1.2 MB Download

Comment 3 by thakis@chromium.org, Mar 11 2016

This is enough too, if it takes more than 1.5s then it'll take more than 60s.

 ../../third_party/llvm-build/Release+Asserts/bin/clang++ -O2 -std=gnu++11 -c foo.ii -o foo.o

Comment 4 by thakis@chromium.org, Mar 11 2016

It's due to r262670

Comment 6 by p...@google.com, Mar 11 2016

It looks like r262916/r262918 reverted r262670 so we might want to roll past that.

Comment 7 by thakis@chromium.org, Mar 11 2016

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Yup, thanks. The figuring out requested by this bug is done, so let's close this. I'll try to do a roll, but the tot bots are currently red due to chromium's msvs2015 switch, so I need to figure that out first.

Comment 8 by thakis@chromium.org, Mar 12 2016

Blocking: 589647

Sign in to add a comment