New issue
Advanced search Search tips

Issue 594110 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

CREDENTIAL: Update the auto-sign-in flag via chooser.

Project Member Reported by mkwst@chromium.org, Mar 11 2016

Issue description

On Thu, Mar 10, 2016 at 9:35 PM, Mike West <mkwst@google.com> wrote:
> We made some changes to the way we turn on auto-sign in, and it looks
> like you're hitting a case we didn't consider. That is, after 
> https://codereview.chromium.org/1735013004, we're only toggling the
> "auto-sign-in" bit on a heuristically-stored credential after the site
> uses the `get()` API to try to obtain it, as we want to ensure that that
> the site understands the credential management API (and can therefore be
> assumed to explain to us when the user signs out). I'd expect the auto-
> sign-in bit to be toggled for the fi.team.tester7@gmail.com account after
> you select it from the chooser; is that the case?

No, if I pick the heuristically-stored credential from the chooser and use it to sign in, then call the API again, I still get the chooser and can't get into the auto sign-in state. Can you see if you can reproduce?

~~~

Bug in the way we're grabbing the form to update.
 
Cc: sabineb@chromium.org
What's the status of this?
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f50b19595faf6392c7ff404443772a1c1893d5c8

commit f50b19595faf6392c7ff404443772a1c1893d5c8
Author: vasilii <vasilii@chromium.org>
Date: Tue Mar 29 10:43:46 2016

Update the |skip_zero_click| flag of a credential when selected in the account chooser.

When we create a PasswordForm from a CredentialInfo, we're stripping out
data that PasswordStore requires in order to find the form in the
database. This breaks the auto-sign-in bit toggle for the credential if
it was saved via our heuristics, and not via the API.

This patch stops truncating PasswordForm to CredentialInfo when passing to CredentialManagerDispatcher.

BUG= 594110 
R=vasilii@chromium.org

patch from issue 1785273002 at patchset 20001 (http://crrev.com/1785273002#ps20001)

Review URL: https://codereview.chromium.org/1832933002

Cr-Commit-Position: refs/heads/master@{#383699}

[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/password_manager/account_chooser_dialog_android.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_state.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_state.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/content/browser/credential_manager_dispatcher.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/content/browser/credential_manager_dispatcher.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/browser/credential_manager_pending_request_task.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/browser/credential_manager_pending_request_task.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/common/credential_manager_types.cc
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/components/password_manager/core/common/credential_manager_types.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/f50b19595faf6392c7ff404443772a1c1893d5c8/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Owner: vasi...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment