New issue
Advanced search Search tips

Issue 594108 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 596097

Blocking:
issue 546953



Sign in to add a comment

Add new builder and tester bot for headless

Project Member Reported by skyos...@chromium.org, Mar 11 2016

Issue description

We would like to have a new builder and tester bot for the Headless Chrome project. The configuration should be the following:

Builder:
- platform: Linux x64
- gn only
- gn args: is_headless=true
- config: debug
- targets: headless_lib headless_tests

Tester:
- test suites: headless_browsertests

The test suite is pretty tiny so both building and testing could happen on the same bot if necessary.
 
Just to clarify, you're looking for actual linux builder and tester bots, not linux machines with Android devices, correct?

Comment 2 by no...@chromium.org, Mar 11 2016

bugs with Infra label are triaged by chrome-infra team, but the request (add builder) is not something chrome-infra does because it is project-specific (as opposed to e.g. get slave machines). Remove "Infra" label?
nodir: I believe this is a request for the entire bot to be set up. This would include (but wouldn't be limited to) slave allocation. Leaving the Infra label on for now until skyostil confirms.
Yes, this includes a request for slaves; and yes linux builder and tester bots are required. No Android devices.
That's correct, thanks for confirming Juan.
Which waterfall do you want these bots to be on?

Comment 7 by perezju@google.com, Mar 14 2016

I'm guessing https://build.chromium.org/p/chromium.linux/console on the "linux" side. Maybe named "Headless Linux" (like our current "Cast Linux"). WDYT Sami?
there's no way we can jump directly onto the main waterfall.

Comment 9 by perezju@google.com, Mar 14 2016

Then https://build.chromium.org/p/chromium.fyi/console ? Or what do you suggest?
Yeah, chromium.fyi would be fine.
Starting with fyi sgtm.
and "headless linux" sounds fine too.
nodir@/jbudorick@, I assume getting the slave machines would be the first step here, followed by configuring them to make the right kind of builds? I'm just wondering who can help get things in motion here? :)
Sorry, meant to file a blocking bug to infra-labs.
skyostil@ to get progress:

1. please file a new bug for new hardware to label:Infra-Labs (OS (Linux?), Bitness, Waterfall (chromium.fyi?)). Ideally find existing slave that'd fit your needs and point to it (see https://build.chromium.org/p/chromium.fyi/buildslaves)
2. create or edit existing recipe to execute tests you want. You don't have to wait for the bot to be allocated to start this, but you can start with dummy recipe which say just compiles chromium and does nothing to iterate later (after #3).
3. wait for your bot to be allocated, make a change to master config (see https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium.fyi) to add your slave (slaves.cfg) and assign it a new builder which would execute your recipe.
4. iterate with your recipe until you get the bot build what you want.
filed the hardware bug on Friday: https://bugs.chromium.org/p/chromium/issues/detail?id=596097
Owner: skyos...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to skyostil to get this off the Untriaged Infra queue.
Cc: skyos...@chromium.org
Owner: perezju@chromium.org
I can take this to help on the master/1st-recipe side.
'is_headless' isn't necessarily a great choice for a build flag. We're trying to move away from large cross-cutting flags (like is_chromecast) and to flags that are more focused on individual features. There is another mechanism (//build/args template files) that we can use to specify that you want to build a particular configuration that we're using for blimp, and we should look into doing that instead.
Good point. I'll look into replacing is_headless with a template. Do we need to block adding the tester on that though? It'd be good to have some coverage in the mean time.
Patch for removing is_headless: https://codereview.chromium.org/1845473003/

Comment 24 Deleted

The build config for the bot landed and we can already see the first couple of attempts (after being totally broken due to no build config) here:
https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%29

But it fails to compile with:
ninja: error: unknown target 'headless_libs', did you mean 'headless_lib'?

Oops, probably my bad. Will fire up a CL to get this fixed.
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1add7215b690ec6a34145c8a74a95714efa9829a

commit 1add7215b690ec6a34145c8a74a95714efa9829a
Author: perezju <perezju@chromium.org>
Date: Fri Apr 15 14:19:54 2016

Fix build config of Headless bot

BUG= 594108 

Review URL: https://codereview.chromium.org/1891153003

Cr-Commit-Position: refs/heads/master@{#387596}

[modify] https://crrev.com/1add7215b690ec6a34145c8a74a95714efa9829a/testing/buildbot/chromium.fyi.json

Status: Fixed (was: Assigned)
And the results are in: https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%29/builds/968

Thanks for the help everyone!
Awesome!

Sign in to add a comment