New issue
Advanced search Search tips

Issue 594105 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Nexus6 Perf (2) failure due to missing CHROMIUM_OUTPUT_DIR

Project Member Reported by picksi@chromium.org, Mar 11 2016

Issue description

failure: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29

smoothness.top_25_smooth failing with the following error:


Traceback (most recent call last):
  File "/b/build/slave/Android_Nexus6_Perf__2_/build/src/third_party/android_platform/development/scripts/stack", line 258, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/build/slave/Android_Nexus6_Perf__2_/build/src/third_party/android_platform/development/scripts/stack", line 194, in main
    constants.CheckOutputDirectory()
  File "/b/build/slave/Android_Nexus6_Perf__2_/build/src/third_party/android_platform/development/scripts/../../../../build/android/pylib/constants/__init__.py", line 264, in CheckOutputDirectory
    raise Exception('Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR '
Exception: Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR has been set

smoothness.top_25_smooth.reference is failing in the same way.

Might just be flaky? Or a change to the execution environment? I will check bot later and close this if it is flakyness..
 

Comment 1 by picksi@chromium.org, Mar 11 2016

Cc: agrieve@chromium.org
@Andrew I believe you have made changes related to CHROMIUM_OUTPUT_DIR? I'm seeing this error occurring in a couple of the bots. Could it be related to your changes?
Owner: stip@chromium.org
stip, can you help triage?
Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Fix in progress: https://codereview.chromium.org/1721653003/
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9bd0519591faf53fc321094970ac99fdc2150c2c

commit 9bd0519591faf53fc321094970ac99fdc2150c2c
Author: agrieve@chromium.org <agrieve@chromium.org>
Date: Fri Mar 11 19:16:34 2016

Make sure CHROMIUM_OUTPUT_DIR is set from runtest.py

BUG= 594105 

Review URL: https://codereview.chromium.org/1721653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299248 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/9bd0519591faf53fc321094970ac99fdc2150c2c/scripts/slave/runtest.py

Looks like this is still failing:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29/builds/2187/steps/smoothness.gpu_rasterization.top_25_smooth/logs/stdio

Note that it prints at the top
Additional test environment:
  CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
  CHROMIUM_OUTPUT_DIR=/b/build/slave/Android_Nexus6_Perf__2_/build/src/out/Release

Tried running the command locally via:
PYTHONPATH=/usr/local/google/home/agrieve/ssd/git/infra/build/scripts:/usr/local/google/home/agrieve/ssd/git/infra/build/scripts/release:/usr/local/google/home/agrieve/ssd/git/infra/build/third_party:/usr/local/google/home/agrieve/ssd/git/infra/build/slave:/usr/local/google/home/agrieve/ssd/git/infra/build/site_config /usr/local/google/home/agrieve/ssd/git/infra/build/scripts/slave/runtest.py --target Debug --test-platform android --no-xvfb '--annotate=graphing' '--results-url=https://chromeperf.appspot.com' '--perf-dashboard-id=smoothness.gpu_rasterization.top_25_smooth' '--perf-id=android-nexus6' '--test-type=smoothness.gpu_rasterization.top_25_smooth' '--step-name=smoothness.gpu_rasterization.top_25_smooth' --chartjson-file /tmp/tmpO_0rlt.json '--builder-name=Android Nexus6 Perf (2)' '--slave-name=build16-b1' '--build-number=2187' --run-python-script /usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/test_runner.py perf --single-step smoothness.gpu_rasterization.top_25_smooth --verbose


And it gets passed the point of failure.

No idea why this is failing...
Mmmm, actually, I don't think I ran it right:

C   24.547s Main  ********************************************************************************
C   24.547s Main  Detailed Logs
C   24.548s Main  ********************************************************************************
C   24.548s Main  ********************************************************************************
C   24.548s Main  Summary
C   24.548s Main  ********************************************************************************
C   24.548s Main  [==========] 3 tests ran.
C   24.548s Main  [  PASSED  ] 2 tests.
C   24.548s Main  [  FAILED  ] 1 test, listed below:
C   24.548s Main  [  FAILED  ] cc54_single_step
C   24.548s Main
C   24.548s Main  1 FAILED TEST
C   24.548s Main  ********************************************************************************
I   24.548s Main  ********************************************************************************
I   24.548s Main  Output from:
I   24.548s Main  smoothness.gpu_rasterization.top_25_smooth --device 0599cc54
I   24.549s Main  ********************************************************************************


Output from run #0:

/bin/sh: smoothness.gpu_rasterization.top_25_smooth: command not found


Output from run #1:

/bin/sh: smoothness.gpu_rasterization.top_25_smooth: command not found
Okay, think I've solved the mystery:

We're setting the var for the step that *prints* test results, but not for the one that actually runs the tests:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29/builds/2187/steps/Sharded%20Perf%20Tests/logs/stdio
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c91b537eb16a73f49e61b08e8d24cfbc4649ed75

commit c91b537eb16a73f49e61b08e8d24cfbc4649ed75
Author: agrieve <agrieve@chromium.org>
Date: Mon Mar 14 19:04:59 2016

test_runner.py: Auto-detect output dir when running on bots

BUG= 594105 , 593973 

Review URL: https://codereview.chromium.org/1799073004

Cr-Commit-Position: refs/heads/master@{#381032}

[modify] https://crrev.com/c91b537eb16a73f49e61b08e8d24cfbc4649ed75/build/android/pylib/constants/__init__.py

Status: Fixed (was: Started)
Components: Infra>Labs
Labels: -Infra-Labs

Sign in to add a comment