Issue metadata
Sign in to add a comment
|
Regression: Quick menu is misplaced after long press in 'Google search box'
Reported by
jshan...@etouch.net,
Mar 11 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2674.0 (Official Build) f9be006501afecf6f58b3d638999e03613314c84-refs/heads/master@{#380495}-32/64 bit OS: Windows(Touch device) Steps: 1. Launch Chrome, open NTP and copy some text to enabled paste 2. Now long press in 'Google search box' and observe. Actual: Quick menu is misplaced after long press in 'Google search box' i.e Cut.Copy,paste.. menu is seen at top L.H.S of page Expected: Quick menu should not be misplaced i.e Cut.Copy,paste.. menu should be seen properly after long press. This is a regression issue broken in M-48, below is bisect info. Good build: 48.0.2555.0 Bad build: 48.0.2556.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/5f61ecb107fd7118621a99fe03b094f37ce04394..7cf5114554aa186956948145acb714cd081a9184?pretty=fuller&n=100 Suspecting: r358148 ? Please help to re-assign if your change is not the cause. Note: This is touch device specific issue.
,
Mar 11 2016
,
Mar 11 2016
jshanbal@: What was the behavior before 48.0.2555.0 (Good build)? Did we show the quick menu in the correct place? Or, we didn't show the quick menu at all? I believe NTP has always been reporting wrong values for selection bounds and because they were out of bounds and/or very small, we didn't show selection handle and the quick menu.
,
Mar 14 2016
With response to comment #3, In 48.0.2555.0 (Good build), quick menu is not seen at all.Instead context menu appears.
,
Mar 14 2016
,
Apr 21 2016
mohsen@; I can still reproduce this issue on 52.0.2714.0. Do we have a plan to address this regression?
,
Jun 14 2016
mohsen@: Ping!
,
Jun 14 2016
Sorry, I forgot to respond to the previous ping. I will take a look at this early next week...
,
Jun 29 2016
mohsen@ have you made any progress?
,
Jul 5 2016
,
Jul 15 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32 commit 6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32 Author: mohsen <mohsen@chromium.org> Date: Fri Jul 22 03:14:08 2016 Move content shell context menu to ShellWebContentsViewDelegate in Views Allows content shell to run context menu handling code in WebContentsViewAura, including touch selection code. This is needed to be able to properly test long press touch selection behavior. BUG= 594101 Review-Url: https://codereview.chromium.org/2132983002 Cr-Commit-Position: refs/heads/master@{#407008} [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/content_shell.gypi [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/BUILD.gn [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell.h [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_android.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_aura.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_mac.mm [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_views.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate.h [add] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate_aura.cc [add] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate_views.cc [delete] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/content/shell/browser/shell_web_contents_view_delegate_win.cc
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41355a89adc05a40f8d6eb1e60a600edb02f8de1 commit 41355a89adc05a40f8d6eb1e60a600edb02f8de1 Author: mohsen <mohsen@chromium.org> Date: Fri Jul 22 04:17:53 2016 Fix long press touch selection on empty text fields Desired behavior when long press happens on an empty text field is to activate touch selection and show the quick menu if there is anything available to show in the quick menu. Otherwise, the regular context menu should be shown. This was regressed due to changes in context menu source type that added LONG_PRESS and LONG_TAP types. In addition to fixing this regression, this CL fixes the regression on the new tab page that shows an incorrectly placed quick menu instead of the context menu. BUG= 594101 Review-Url: https://codereview.chromium.org/2124913002 Cr-Commit-Position: refs/heads/master@{#407059} [modify] https://crrev.com/41355a89adc05a40f8d6eb1e60a600edb02f8de1/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc [modify] https://crrev.com/41355a89adc05a40f8d6eb1e60a600edb02f8de1/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc [modify] https://crrev.com/41355a89adc05a40f8d6eb1e60a600edb02f8de1/content/test/data/touch_selection.html [modify] https://crrev.com/41355a89adc05a40f8d6eb1e60a600edb02f8de1/ui/touch_selection/touch_selection_controller.h
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32 commit 6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32 Author: mohsen <mohsen@chromium.org> Date: Fri Jul 22 03:14:08 2016 Move content shell context menu to ShellWebContentsViewDelegate in Views Allows content shell to run context menu handling code in WebContentsViewAura, including touch selection code. This is needed to be able to properly test long press touch selection behavior. BUG= 594101 Review-Url: https://codereview.chromium.org/2132983002 Cr-Commit-Position: refs/heads/master@{#407008} [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/content_shell.gypi [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/BUILD.gn [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell.h [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_android.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_aura.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_mac.mm [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_views.cc [modify] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate.h [add] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate_aura.cc [add] https://crrev.com/6eb57fb790e8c319cc80d9d6a9d5ff5f6d042e32/content/shell/browser/shell_web_contents_view_delegate_views.cc [delete] https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac/content/shell/browser/shell_web_contents_view_delegate_win.cc
,
Jul 22 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bokan@chromium.org
, Mar 11 2016