Issue metadata
Sign in to add a comment
|
Regression: On 'find in page' box unnecessary 'Previous' and 'Next' arrow button is enabled.
Reported by
rk...@etouch.net,
Mar 11 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2674.0 Revision f9be006501afecf6f58b3d638999e03613314c84-refs/heads/master@{#380495}(32/64 bit) OS: Windows(Win-7 Aero Enabled), Linux What steps will reproduce the problem? (1) Launch chrome,open NTP and press ctrl+F, observe Unnecessary Previous and Next arrow button is enabled without entered any keyword on find in box. Previous and Next arrow should be disable if there is no keyword entered. This is a regression issue,broken in 'M-50', below is bisect info: Good Build: 50.0.2644.0 Bad Build: 50.0.2646.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/ef3511f30c78a2e286c7dc427b2af18ec54cb0c9..f1777a5bee5a24d196deab700bf4c4a5e118a156?pretty=fuller&n=100 Suspecting: r374578 Note: Issue is not seen on Mac OS.
,
Mar 11 2016
I can confirm that r374578 is the cause for this regression. I will submit a CL to address this issue.
,
Mar 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc0733e0630499bea163c4f3cf826c945e7baaf commit afc0733e0630499bea163c4f3cf826c945e7baaf Author: m.pistrich <m.pistrich@gmail.com> Date: Mon Mar 14 21:29:40 2016 Disable Find-In-Page buttons when no text is entered This CL fixes a regression caused by https://crrev.com/1660273003 which enables the buttons of the Find-In-Page bar even if no text is entered or no search was issued yet. R=msw@chromium.org BUG= 594097 TEST=FindInPageTest.ButtonsDisabledWithoutText Review URL: https://codereview.chromium.org/1785033004 Cr-Commit-Position: refs/heads/master@{#381074} [modify] https://crrev.com/afc0733e0630499bea163c4f3cf826c945e7baaf/chrome/browser/ui/views/find_bar_host.cc [modify] https://crrev.com/afc0733e0630499bea163c4f3cf826c945e7baaf/chrome/browser/ui/views/find_bar_view.cc [modify] https://crrev.com/afc0733e0630499bea163c4f3cf826c945e7baaf/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc
,
Mar 14 2016
Let's verify the fix on the next canary and then we can merge to M-50 (2661). Thanks for the patch, m.pistrich!
,
Mar 15 2016
Thank you for the fix. It is working as intended on Latest Canary#51.0.2679.0. We have a Beta cut today @ 5PM PST and it would be nice if you can merge request (by adding "Merge=Request-50" label) this to Beta branch:2661 at the earliest.
,
Mar 15 2016
,
Mar 15 2016
This is fixed on 51.0.2679.0 canary, requesting merge to M50 (branch 2661).
,
Mar 15 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/820c22f3b79c9af3f6c6c876ae515ec65606a43b commit 820c22f3b79c9af3f6c6c876ae515ec65606a43b Author: Michael Wasserman <msw@chromium.org> Date: Tue Mar 15 20:40:03 2016 [M50 Merge] Disable Find-In-Page buttons when no text is entered This CL fixes a regression caused by https://crrev.com/1660273003 which enables the buttons of the Find-In-Page bar even if no text is entered or no search was issued yet. R=msw@chromium.org BUG= 594097 TEST=FindInPageTest.ButtonsDisabledWithoutText Review URL: https://codereview.chromium.org/1785033004 Cr-Commit-Position: refs/heads/master@{#381074} (cherry picked from commit afc0733e0630499bea163c4f3cf826c945e7baaf) Review URL: https://codereview.chromium.org/1801313003 . Cr-Commit-Position: refs/branch-heads/2661@{#248} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/820c22f3b79c9af3f6c6c876ae515ec65606a43b/chrome/browser/ui/views/find_bar_host.cc [modify] https://crrev.com/820c22f3b79c9af3f6c6c876ae515ec65606a43b/chrome/browser/ui/views/find_bar_view.cc [modify] https://crrev.com/820c22f3b79c9af3f6c6c876ae515ec65606a43b/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc
,
Mar 15 2016
Merged to M50 in http://codereview.chromium.org/1801313003 please help verify. Thanks, m.pistrich!
,
Mar 16 2016
Verified the fix on Windows 7 & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 50.0.2661.37 Screen-recording is attached. TE-Verified labels are added.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 11 2016