New issue
Advanced search Search tips

Issue 594087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

html/semantics/forms/the-input-element/checked.xhtml fails

Project Member Reported by tkent@chromium.org, Mar 11 2016

Issue description

Version: 51 canary
OS: All

What steps will reproduce the problem?
(1) Open http://w3c-test.org/html/semantics/forms/the-input-element/checked.xhtml

What is the expected output? What do you see instead?
Expected: The test passes.
Actual: The test fails.


Please use labels and text to provide additional information.
For some reason, 'checked' IDL attribute of INPUT element is indeterminate until INPUT parsing is finished.  Usually this doesn't cause problems, but it's visible if the document is an XML and it has <input><script>...</script></input>.

Pri-3 because this is not a practical scenario at all.

 

Comment 1 by tkent@chromium.org, Jun 22 2016

Labels: Hotlist-Interop
Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6ceb18476472a0a87345b86ed8fd7c2674ef00

commit be6ceb18476472a0a87345b86ed8fd7c2674ef00
Author: tkent <tkent@chromium.org>
Date: Thu Jun 23 10:40:15 2016

Delay to apply |checked| attribute only if the document has form state to be restored.

We delayed to apply |checked| attribute of INPUT element until
finishParsingChildren() in order to restore radio button group state
correctly. Web authors can't observe this delay in HTML documents because INPUT
can't have children, but could observe it in XHTML documents.

We don't need to delay it if we don't restore form state.  This CL makes a WPT
test passing.

BUG= 594087 

Review-Url: https://codereview.chromium.org/2089053002
Cr-Commit-Position: refs/heads/master@{#401576}

[delete] https://crrev.com/09978065078e42b239aaaed8ae4add27c6fb0e8d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/checked-expected.txt
[modify] https://crrev.com/be6ceb18476472a0a87345b86ed8fd7c2674ef00/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/be6ceb18476472a0a87345b86ed8fd7c2674ef00/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/be6ceb18476472a0a87345b86ed8fd7c2674ef00/third_party/WebKit/Source/core/html/forms/FormController.h

Comment 3 by tkent@chromium.org, Jun 23 2016

Labels: M-53
Status: Fixed (was: Started)

Sign in to add a comment