Issue metadata
Sign in to add a comment
|
[Regression] User Classic theme seen improper color in tab strip |
||||||||||||||||||||||
Issue descriptionVersion: 51.0.2674.0 dev channel OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome navigate to setting tabs"chrome://settings/" (2)Go to Appearance click on"User classic theme" and observe the tab strip color What is the expected output? Tab strip color should be proper(blue) What do you see instead? Instead its color is seen improper(Gray)[Refer the video] This is a regression issue broken in M51. Note: Issue is not applicable for windows. Good Build:51.0.2666.0 Bad Build:51.0.2667.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a9af97d82c54e699fb369db0fdc8e44923af03d7..e4dae472b2f122a5c93dc3f7338ee946eda677b1 Suspecting https://codereview.chromium.org/1726743003 from changelog @jonross: Please feel free to re-assign if its not related to your change
,
Mar 11 2016
+tdanderson@
With M51 the Material Design theme changes are on by default for Linux.
Terry: - Are grey tabs expected for the MD theme on Linux?
- If so the theme settings page is a bit misleading now. "Classic" theme on Linux always meant the Chrome default, which was blue. However with us changing the defaults that button seems to imply the 'pre-MD' theme. We likely need to update the settings page to reflect what the buttons actually do:
"Get Themes" "Use GTK Theme" "Use Chrome's Default"
,
Mar 11 2016
sb00348987@, please post screenshots rather than videos. As I understand it, yes, grey tabs are expected for MD on Linux. "Classic" is still going to map to Chrome's default, but that default is changing to MD. Handing this off to Evan who is leading MD on Linux.
,
Mar 15 2016
the actual bug here is that the frame color is supposed to be grey, not blue. The background tabs are correct.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4db9673a67b98e1bdd7adeb1a866b3e940593ba commit a4db9673a67b98e1bdd7adeb1a866b3e940593ba Author: estade <estade@chromium.org> Date: Tue Mar 15 01:51:48 2016 MD - make classic theme frame colors on Linux/Win the same as CrOS. (When using OpaqueBrowserFrameView) BUG= 594076 Review URL: https://codereview.chromium.org/1798323002 Cr-Commit-Position: refs/heads/master@{#381149} [modify] https://crrev.com/a4db9673a67b98e1bdd7adeb1a866b3e940593ba/chrome/browser/themes/theme_properties.cc
,
Mar 15 2016
,
May 29 2016
> the actual bug here is that the frame color is supposed to be grey, not blue. The color has always been blue on Linux, and I like it more than the dull gray color. I made a theme to get the blue color back. Incognito Chrome 51 was too dark for my taste: https://chrome.google.com/webstore/detail/classic-blue-theme-back-t/jammgopjmlachkjhifkdjccbphdcapei |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Mar 11 2016