New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594066 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.8%-30.6% regression in oortonline at 380399:380416

Project Member Reported by mlippautz@chromium.org, Mar 11 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=594066

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggL7DpwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA_5__twoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggNKnsgoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
Cc: hpayer@chromium.org u...@chromium.org jochen@chromium.org
Timed out waiting for a failed build. Launching new job because we have a fix for that situation now.
Cc: ashej...@chromium.org
Labels: TE-Triaged
Bisect re-kicked with wider revision range.

Details on the below link:
-------------------------
https://chromeperf.appspot.com/group_report?bug_id=594066

Thank you!
Bisect re-kicked as the previous bisect failed.

Details on the link below:
==========================
https://chromeperf.appspot.com/group_report?bug_id=594066

Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 15 2016

Cc: jmad...@chromium.org
Owner: jmad...@chromium.org

=== Auto-CCing suspected CL author jmadill@chromium.org ===

Hi jmadill@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : D3D: Fix static promotion of dynamic index data.
Author  : Jamie Madill
Commit description:
  
The static promotion somehow slipped into the direct usage check,
meaning we would never promote dynamic index data to static, even
if unchanged for many frames. Fix this by putting the update back
in the correct place.

BUG= angleproject:1334 

Change-Id: I90897fcd2f6a2b231ccef9f1fa044d276b238b56
Reviewed-on: https://chromium-review.googlesource.com/331388
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit  : 0e49e6b5f00ed93e72a3b66ab8e8b510b2581a42
Date    : Thu Mar 10 00:55:14 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@380350         6270.0      211.068709  5           good
chromium@380407         6206.0      210.19039   5           good
chromium@380412         6212.0      198.796378  5           good
chromium@380413         6254.0      111.040533  5           good
chromium@380413,angle@7d8585b8026376.0      114.149025  5           good
chromium@380413,angle@3f01e6c2536414.0      196.672316  5           good
chromium@380413,angle@0e49e6b5f04364.0      45.607017   5           bad         <-
chromium@380414         4334.0      92.357999   5           bad
chromium@380415         4348.0      51.672043   5           bad
chromium@380417         4308.0      16.431677   5           bad
chromium@380432         4392.0      44.94441    5           bad
chromium@380460         4380.0      67.082039   5           bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 594066

Test Command: python src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --also-run-disabled-tests oortonline
Test Metric: Total/http___oortonline.gl__run
Relative Change: 30.14%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/890
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015417389570150704


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=594066

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Started (was: Assigned)
Will investigate.
Can confirm the pinpointed CL does seem to regress the benchmark, still investigating.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d

commit e4857c7d39c1dff84e26fb0d8783fc2bcde1022d
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Apr 21 18:13:53 2016

Buffer11: Use adaptive threshold for releasing system memory.

The hard-coded threshold of five uses before a release was regressing
the Oort online benchmark, which seems to use an index buffer many
times, then change to a different range of indices, which would need
to check the system memory for index range validation.

Also add a performance regression test, and an update to the perf
runner script which checks for the most recent binary among the search
directories.

BUG= 594066 

Change-Id: Id09cc32fd00bff1c72cbe9b6fb7c210fd047a551
Reviewed-on: https://chromium-review.googlesource.com/339271
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
[modify] https://crrev.com/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d/src/tests/perf_tests/IndexConversionPerf.cpp
[modify] https://crrev.com/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d/src/libANGLE/renderer/d3d/d3d11/Buffer11.h
[modify] https://crrev.com/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d/scripts/perf_test_runner.py
[modify] https://crrev.com/e4857c7d39c1dff84e26fb0d8783fc2bcde1022d/src/tests/perf_tests/ANGLEPerfTest.h

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0ce63eb1d920412f2c16c2d15b600137619ce8

commit 3f0ce63eb1d920412f2c16c2d15b600137619ce8
Author: jmadill <jmadill@chromium.org>
Date: Mon Apr 25 18:49:40 2016

Roll ANGLE b97a3e7..82c47ad

https://chromium.googlesource.com/angle/angle.git/+log/b97a3e7..82c47ad

BUG= 594066 
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1920763003

Cr-Commit-Position: refs/heads/master@{#389527}

[modify] https://crrev.com/3f0ce63eb1d920412f2c16c2d15b600137619ce8/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0ce63eb1d920412f2c16c2d15b600137619ce8

commit 3f0ce63eb1d920412f2c16c2d15b600137619ce8
Author: jmadill <jmadill@chromium.org>
Date: Mon Apr 25 18:49:40 2016

Roll ANGLE b97a3e7..82c47ad

https://chromium.googlesource.com/angle/angle.git/+log/b97a3e7..82c47ad

BUG= 594066 
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1920763003

Cr-Commit-Position: refs/heads/master@{#389527}

[modify] https://crrev.com/3f0ce63eb1d920412f2c16c2d15b600137619ce8/DEPS

Status: Fixed (was: Started)
Graphs seem to have recovered.

Sign in to add a comment