Regression: Chrome browser gets crashed after clicking on 'PDF viewer' extension icon.
Reported by
rk...@etouch.net,
Mar 11 2016
|
||||||||||||
Issue descriptionChrome Version: 51.0.2673.0 Revision 764e6bb1b05458cde3ca0702ceb801d25c3dcc3b-refs/heads/master@{#380313} OS: Windows(win-7 Aero Enabled), Linux Precondition: Enable "Extension toolbar redesign" flag from chrome://flags URL: https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?utm_source=chrome-ntp-icon What steps will reproduce the problem? (1) Launch chrome,navigate to above url and click on 'ADD TO CHROME' button. (2) Open pdf file(e.g.http://www.orimi.com/pdf-test.pdf),right click on newly added extension & select 'Hide in chrome menu' option. (3) Now open wrench menu, click on zoom out icon then extension icon and observe. Chrome browser gets crashed Crash ID a7919cb400000000 (Chrome) Chrome browser should not crash. This is a regression issue,broken in 'M-48', below is bisect info: Good Build: 48.0.2544.0 Bad Build: 48.0.2546.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/8fc5ec7879e78806a00e6755e4bd8ab0ffd07df2..615479bb713dd274decd8facfb2694fffe83a372?pretty=fuller&n=100 Suspecting: r356088 Could you please help me to reassign this issue,if your change is not cause for it? Note: Issue is not seen on Mac OS.
,
Mar 11 2016
,
Mar 11 2016
the stack is show AppMenu::ZoomView::ZoomLabelMaxWidth() as the last frame
,
Mar 14 2016
This isn't a regression because it depends on a flag flip. Also, component extensions shouldn't show up in the extensions toolbar AFAIK? This may not be an issue on trunk.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6 commit 03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 15 21:56:19 2016 [UI Views] Check menu() in ZoomView AppMenuView::menu() documents that it may be null during shutdown, but ZoomView doesn't check it. Add a check. BUG= 594055 Review URL: https://codereview.chromium.org/1803003003 Cr-Commit-Position: refs/heads/master@{#381329} [modify] https://crrev.com/03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6/chrome/browser/ui/views/toolbar/app_menu.cc
,
Mar 15 2016
Should be fixed. Requesting merge to M50.
,
Mar 18 2016
,
Mar 18 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b91862628b99b50dc811079000d0b16c48c4269 commit 0b91862628b99b50dc811079000d0b16c48c4269 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 18 22:47:53 2016 [UI Views] Check menu() in ZoomView AppMenuView::menu() documents that it may be null during shutdown, but ZoomView doesn't check it. Add a check. BUG= 594055 Review URL: https://codereview.chromium.org/1803003003 Cr-Commit-Position: refs/heads/master@{#381329} (cherry picked from commit 03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6) Review URL: https://codereview.chromium.org/1821433002 . Cr-Commit-Position: refs/branch-heads/2661@{#290} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/0b91862628b99b50dc811079000d0b16c48c4269/chrome/browser/ui/views/toolbar/app_menu.cc
,
Mar 22 2016
Verified the fix on Windows 7, MAC (10.11.3) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 50.0.2661.48 Screen-recording is attached. TE-Verified Labels are added.
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by dbeam@chromium.org
, Mar 11 2016