New issue
Advanced search Search tips

Issue 594054 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 593872
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

86% regression in cc_perftests at 380376:380384

Project Member Reported by kouhei@chromium.org, Mar 11 2016

Issue description

See the link to graphs below.
 

Comment 1 by kouhei@chromium.org, Mar 11 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=594054

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggKattwoM


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 11 2016

Mergedinto: 593872
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Enable the allocator shim on Linux Desktop / CrOS
Author  : primiano
Commit description:
  
This CL enables the shim introduced in crrev.com/1675143004 by
default, only Linux desktop and CrOS.
This CL is functionally a no-op, in the sense that does not change
the default allocator (which remains tcmalloc on Linux/CrOS) and does
not introduce any new feature (other than the possibility, for future
CLs to install hooks in the allocator path).

See crrev.com/1675143004 for a longer description about the allocator
shim and the design doc bit.ly/allocator-shim.

Note for stability sheriffs
---------------------------
If you see suspicious crashes in tcmalloc (especially in free/tc_free)
there are pretty good chances that something unexpectedly went wrong
here and this CL is the culprit.

Note for perf sheriffs
----------------------
There is a possibility that this CL might cause a regression on the
perf waterfalls (only on Linux/CrOS bots) due to  crbug.com/593344 .
The telemetry tests I tried to run locally were all inconclusive.
Should a regression happen, a temporary workaround is possible as
discussed in https://codereview.chromium.org/1675143004/#msg38.

BUG=550886
TEST=base_unittests (AllocatorShimTest.*,OutOfMemoryDeathTest.*,TCMalloc*)

Review URL: https://codereview.chromium.org/1781573002

Cr-Commit-Position: refs/heads/master@{#380377}
Commit  : 8712d70e87c419af545e2bad088126d0e19eb384
Date    : Thu Mar 10 09:19:17 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@380375         837.634094  1.195173    8           good
chromium@380376         837.009369  1.34597     8           good
chromium@380377         1546.017358 4.257835    5           bad
chromium@380378         1545.315527 1.312393    5           bad
chromium@380380         1544.581958 3.598989    5           bad
chromium@380384         1546.801926 2.338729    8           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 594054

Test Command: ./src/out/Release/cc_perftests --test-launcher-print-test-stdio=always
Test Metric: calc_draw_props_time/bsp_tree_cubes
Relative Change: 84.46%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6304
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018506712334017376


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Sign in to add a comment