New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594033 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
karandeepb@chromium.org
█ spqc...@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 672343


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews: failing views_unittests when run with --single-process-tests

Project Member Reported by tapted@chromium.org, Mar 11 2016 
Chrome Version       : 50.0.2661.18
OS Version: OS X 10.11.3

Running views_unittests --single-process-tests results in some test failures. It's probably to do with the different ways a window may be activated/painted when run a non-sharded test harness.

(It's possible some of these are not mac-specific). The number of failing things really surprises me..

HorizontalSliderTest.UpdateFromClickHorizontal
TableViewTest.GetPaintRegion
TableViewTest.Resize
TableViewTest.ResizeViaGesture
TableViewTest.SortOnMouse
TextfieldTest.TextCursorDisplayTest
ViewTargeterTest.ViewTargeterForScrollEvents
ViewTargeterTest.ViewTargeterForGestureEvents
ViewTargeterTest.GestureEventCoordinateConversion
ViewTargeterTest.HitTestCallsOnView
ViewTest.MouseEvent
ViewTest.DeleteOnPressed
ViewTest.PaintWithMovedViewUsesCache
ViewTest.PaintIntersectsOneChild
ViewTest.GetEventHandlerForRect
ViewTest.CanProcessEventsWithinSubtree
ViewTest.NotifyEnterExitOnChild
ViewTest.TransformPaint
ViewTest.TransformEvent
ViewTest.SetBoundsPaint
ViewTest.AddAndRemoveSchedulePaints
ViewTest.ConversionsWithTransform
ViewTest.ConversionsToFromScreen
ViewTest.ConvertRectWithTransform
ViewTest.ScopedTargetHandlerReceivesEvents
ViewLayerTest.LayerToggling
ViewLayerTest.LayerAnimator
ViewLayerTest.BoundsChangeWithLayer
ViewLayerTest.ScheduledRectsInParentAfterSchedulingPaint
ViewLayerTest.VisibilityChildLayers
ViewLayerTest.SnapLayerToPixel
NativeWidgetMacTest.SetCursor
NativeWidgetMacTest.SchedulePaintInRect_Titled
NativeWidgetMacTest.SchedulePaintInRect_Borderless
RootViewTest.ContextMenuFromLongPress
RootViewTest.DeleteViewOnMouseEnterDispatch

Comment 1 Deleted

Comment 2 by spqc...@chromium.org, Apr 13 2016

Owner: ----

Comment 3 by tapted@chromium.org, Apr 13 2016

Cc: karandeepb@chromium.org spqc...@chromium.org ellyjo...@chromium.org
Labels: -M-51 M-52
Oh! This one. Yeah this one is strange. I just ran views_unittests --single-process-tests on Windows and they all passed, so I think this is specific to Mac, but it might not be a blocker for getting the bot up.

It's likely that there's some central problem that will fix a whole bunch of them at once, but I haven't looked into it yet. There wasn't anything immediately evident from the spew of test output.

Perhaps some swizzler or other global state that's not being cleaned up properly.

Comment 4 by lafo...@chromium.org, Apr 20 2016

Labels: -Hotlist-MacViews Proj-MacViews

Comment 5 by tapted@chromium.org, May 31 2016

Labels: -Pri-1 -M-52 Pri-2
removing milestone - it's unclear where this should fit in our priorities (I don't think the priority is "high").

Comment 6 by tapted@chromium.org, Dec 12 2016

Blocking: 672343

Comment 7 by ellyjo...@chromium.org, Apr 12 2017

Labels: MacViews-Cleanup

Comment 8 by ellyjo...@chromium.org, Mar 29 2018

Status: WontFix (was: Available)
MacViews triage: these aren't any less stable with --single-process now.
►

Sign in to add a comment