New issue
Advanced search Search tips

Issue 593996 link

Starred by 1 user
Status: Fixed
Owner:
brucedaw...@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

XFA-Forms in Pdfium broke VS 2015

Project Member Reported by brucedaw...@chromium.org, Mar 11 2016 
Change crrev.com/1775173002 seems to have broken VS 2015 builds. The errors are:

The error's produced say:

d:\src\chromium\src\third_party\pdfium\third_party\libtiff\tiffiop.h(57): warning C4273: '_lfind': inconsistent dll linkage

This appears to be because HAVE_SEARCH_H is not defined, and it should be for Windows builds as search.h is available in the Windows 10 SDK, for VS 2013 and VS 2015. Presumably we "got lucky" with VS 2013 and the conflict is not hit.

Comment 1 by brucedaw...@chromium.org, Mar 11 2016

Blocking: -440500
crrev.com/1781043005 and a pdfium roll will resolve this, but meanwhile the enabling of XFA was reverted for other reasons so this is no longer blocking.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24e0d5ecba7a1c43f87015254142666f0d6db1c2

commit 24e0d5ecba7a1c43f87015254142666f0d6db1c2
Author: ochang <ochang@chromium.org>
Date: Sat Mar 12 01:00:53 2016

Roll PDFium f1fa151..5526501

https://pdfium.googlesource.com/pdfium.git/+log/f1fa151..5526501

BUG= 593996 , 440500 , 591137 

TEST=bots
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1787883003

Cr-Commit-Position: refs/heads/master@{#380814}

[modify] https://crrev.com/24e0d5ecba7a1c43f87015254142666f0d6db1c2/DEPS

Comment 3 by dsinclair@chromium.org, May 18 2016

Owner: brucedaw...@chromium.org
Status: Assigned (was: Untriaged)
Can this be closed? XFA has been re-enabled and I haven't heard any complaints?

Comment 4 by brucedaw...@chromium.org, May 18 2016

Status: Fixed (was: Assigned)
Yep, it must be fixed.
►

Sign in to add a comment