Tracker for updates to the Material Design changes to the chrome settings side nav
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d4b02bdc8617296acb108c67ccaa246ef2f37ee commit 2d4b02bdc8617296acb108c67ccaa246ef2f37ee Author: dschuyler <dschuyler@chromium.org> Date: Fri Mar 11 22:10:41 2016 [MD settings] reorder and update settings sections This CL reorders the sections in the MD settings to more closely match the order listed in the Combined Chrome Settings Hierarchy doc. The entries in the side nav have also been reordered and some menu items were added to flesh out the full menu (even though the sections are not complete). There are some TODOs for icons that will happen in a later CL. BUG= 593989 Review URL: https://codereview.chromium.org/1779423002 Cr-Commit-Position: refs/heads/master@{#380749} [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/app/settings_chromium_strings.grdp [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/app/settings_google_chrome_strings.grdp [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/app/settings_strings.grdp [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c2c0b6d78278126617f352711e22ff0baa59277 commit 4c2c0b6d78278126617f352711e22ff0baa59277 Author: dschuyler <dschuyler@chromium.org> Date: Sat Mar 12 04:57:20 2016 [MD settings] change side nav icons - remove cloud print item The brightness-1 (dot) icons are replaced with better icons for the settings side nav. The Google Cloud Print menu item was removed because that's not in the first MD settings pass. BUG= 593989 Review URL: https://codereview.chromium.org/1790463004 Cr-Commit-Position: refs/heads/master@{#380863} [modify] https://crrev.com/4c2c0b6d78278126617f352711e22ff0baa59277/chrome/browser/resources/settings/settings_menu/settings_menu.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73a95df58dd368559e693279c7875b9808bd04d7 commit 73a95df58dd368559e693279c7875b9808bd04d7 Author: dschuyler <dschuyler@chromium.org> Date: Thu Mar 17 18:34:22 2016 [MD settings] change side nav and section labels This CL updates the section names (shown on the side nav and above each section). They use sentence case. The & symbol is replaced with 'and'. The Reset and Languages names have been shortened. BUG= 593989 Review URL: https://codereview.chromium.org/1803363003 Cr-Commit-Position: refs/heads/master@{#381757} [modify] https://crrev.com/73a95df58dd368559e693279c7875b9808bd04d7/chrome/app/settings_strings.grdp [modify] https://crrev.com/73a95df58dd368559e693279c7875b9808bd04d7/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d22fae34f47ce95aee43167fef1eb3f6cb231a0a commit d22fae34f47ce95aee43167fef1eb3f6cb231a0a Author: dpapad <dpapad@chromium.org> Date: Tue Mar 22 22:02:51 2016 MD Settings: Fix side navigation bar background color for RTL. BUG= 593989 Review URL: https://codereview.chromium.org/1828493002 Cr-Commit-Position: refs/heads/master@{#382698} [modify] https://crrev.com/d22fae34f47ce95aee43167fef1eb3f6cb231a0a/chrome/browser/resources/settings/settings_ui/settings_ui.html
Settings Navigation spec: https://docs.google.com/document/d/1rQ5lc9-cjb8ZCue4AZfMW6QSiJhs6ygZes9MuwU9g6s/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46c22835a225bc3c6361a45fa3558400eb7b5dd commit e46c22835a225bc3c6361a45fa3558400eb7b5dd Author: dschuyler <dschuyler@chromium.org> Date: Fri Apr 29 23:32:19 2016 [MD settings] side nav routing to page sections This CL makes the side nav show the correct settings section when selecting a page in the menu. Several routes have been added for top-level pages (non-subpages). A SettingsRoute closure type has been defined. BUG= 604942 , 593989 , 584478 , 606632 Review-Url: https://codereview.chromium.org/1916323002 Cr-Commit-Position: refs/heads/master@{#390802} [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_router.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/test/data/webui/settings/people_page_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c91001b6a3ba733e8500548a706196e394a44be8 commit c91001b6a3ba733e8500548a706196e394a44be8 Author: dschuyler <dschuyler@chromium.org> Date: Thu May 05 19:18:19 2016 [MD settings] unit test for settings-menu This CL add some basic tests for settings-menu. BUG= 593989 Review-Url: https://codereview.chromium.org/1952863002 Cr-Commit-Position: refs/heads/master@{#391866} [modify] https://crrev.com/c91001b6a3ba733e8500548a706196e394a44be8/chrome/test/data/webui/settings/cr_settings_browsertest.js [add] https://crrev.com/c91001b6a3ba733e8500548a706196e394a44be8/chrome/test/data/webui/settings/settings_menu_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2092cc4a8d305eeb385c53a850e00178d836e8f commit f2092cc4a8d305eeb385c53a850e00178d836e8f Author: dschuyler <dschuyler@chromium.org> Date: Wed May 11 01:04:11 2016 [MD settings] remove extraneous item-icon attributes This CL cleans up some old item-icon attributes on the side nav menu items. BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1967663005 Cr-Commit-Position: refs/heads/master@{#392799} [modify] https://crrev.com/f2092cc4a8d305eeb385c53a850e00178d836e8f/chrome/browser/resources/settings/settings_menu/settings_menu.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffbbd3f14353bf8d981ccbddff84a48a8326c936 commit ffbbd3f14353bf8d981ccbddff84a48a8326c936 Author: dschuyler <dschuyler@chromium.org> Date: Sat May 28 00:55:24 2016 [MD settings] refine routing function This CL adds a way for animated pages to detect which page a subpage resides within. Previously, the page was assumed to be the same as the currentRoute page. That's still true at the moment, but when we change to having the basic and advanced pages shown together, the currentRoute page may not match up correctly. This CL sets the page more explicitly so that the user can jump between basic and advanced subpages. This is a step toward showing basic and advanced settings together. BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2018753002 Cr-Commit-Position: refs/heads/master@{#396615} [modify] https://crrev.com/ffbbd3f14353bf8d981ccbddff84a48a8326c936/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/ffbbd3f14353bf8d981ccbddff84a48a8326c936/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/ffbbd3f14353bf8d981ccbddff84a48a8326c936/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/ffbbd3f14353bf8d981ccbddff84a48a8326c936/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/ffbbd3f14353bf8d981ccbddff84a48a8326c936/chrome/browser/resources/settings/settings_page_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70ae59c616a8f0b948c143a29027cbf7a8872851 commit 70ae59c616a8f0b948c143a29027cbf7a8872851 Author: dschuyler <dschuyler@chromium.org> Date: Wed Jun 08 00:37:54 2016 [MD settings] redesign of side nav This CL reworks the side nav menu to remove the 'basic' menu label while keeping the items in the basic menu displayed. The 'advanced' page is now toggled separately from the basic page. An 'Advanced' toggle button has also been added to the content area which will expand or collapse the advanced settings. BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2008843003 Cr-Commit-Position: refs/heads/master@{#398434} [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/compiled_resources2.gyp [add] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/70ae59c616a8f0b948c143a29027cbf7a8872851/chrome/test/data/webui/settings/settings_menu_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe571aa0319d7588b2ef12d7917732a6e7b24ac commit ebe571aa0319d7588b2ef12d7917732a6e7b24ac Author: dschuyler <dschuyler@chromium.org> Date: Sat Jun 18 00:40:29 2016 [MD settings] Remove old side nav code; remove extra toolbar This CL effectively reverts CLs 1060983004 and 1039373002. The side nav toolbar is exchanged for a simpler div and the on menu select event is changed for an on activate which has better scope for the usage. BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2076193003 Cr-Commit-Position: refs/heads/master@{#400554} [modify] https://crrev.com/ebe571aa0319d7588b2ef12d7917732a6e7b24ac/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/ebe571aa0319d7588b2ef12d7917732a6e7b24ac/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/ebe571aa0319d7588b2ef12d7917732a6e7b24ac/chrome/browser/resources/settings/settings_ui/settings_ui.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9 commit 13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9 Author: dschuyler <dschuyler@chromium.org> Date: Fri Jul 01 23:50:50 2016 [MD settings] set route on advanced page toggle This is a fix to set the route properly when going to basic or advanced pages (without going to a section within the page). BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2111223002 Cr-Commit-Position: refs/heads/master@{#403565} [modify] https://crrev.com/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9/chrome/browser/resources/settings/settings_page/settings_router.js
This should be fixed once this lands: https://codereview.chromium.org/2090753002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68a872b1209e48315f408d5d1693d2636df299b1 commit 68a872b1209e48315f408d5d1693d2636df299b1 Author: dschuyler <dschuyler@chromium.org> Date: Mon Jul 25 21:24:40 2016 [MD settings] end of page padding in content area This CL adds (somewhat) dynamic padding to the end of the MD settings so that the last item may scroll to the top of the page when selected in the side nav menu. BUG= 593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2090753002 Cr-Commit-Position: refs/heads/master@{#407581} [modify] https://crrev.com/68a872b1209e48315f408d5d1693d2636df299b1/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/68a872b1209e48315f408d5d1693d2636df299b1/chrome/browser/resources/settings/settings_main/settings_main.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f2d9d4a9232dc7062689261a40a76e577d80a25 commit 7f2d9d4a9232dc7062689261a40a76e577d80a25 Author: michaelpg <michaelpg@chromium.org> Date: Wed Jul 27 07:55:50 2016 MD Settings: Flush templates in settings-main before checking An odd interleaving of async calls can cause dom-ifs not to be updated yet in a function scheduled by async(). This causes expected elements to not exist at the moment we look for them, even though the properties are correct. TBR=tommycli@chromium.org BUG= 631891 , 593989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2182283003 Cr-Commit-Position: refs/heads/master@{#408074} [modify] https://crrev.com/7f2d9d4a9232dc7062689261a40a76e577d80a25/chrome/browser/resources/settings/settings_main/settings_main.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46ffd77c225d30b65092545efe2712589e611601 commit 46ffd77c225d30b65092545efe2712589e611601 Author: dschuyler <dschuyler@chromium.org> Date: Wed Aug 03 23:46:33 2016 [MD settings] shrink overscroll when scrolling up This CL will shrink the overscroll height at the bottom of the page while scrolling the content. It also adds a minimum height for the overscroll to allow space for the advanced page content to be seen when the Advanced Toggle is used. BUG= 593989 , 631249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2206723002 Cr-Commit-Position: refs/heads/master@{#409669} [modify] https://crrev.com/46ffd77c225d30b65092545efe2712589e611601/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/46ffd77c225d30b65092545efe2712589e611601/chrome/browser/resources/settings/settings_main/settings_main.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/774641b646fbb2b61818ba6637e356a06815932f commit 774641b646fbb2b61818ba6637e356a06815932f Author: dschuyler <dschuyler@chromium.org> Date: Tue Aug 23 02:40:55 2016 [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG= 593989 , 629783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2267133002 Cr-Commit-Position: refs/heads/master@{#413645} [modify] https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f/chrome/browser/resources/settings/settings_menu/settings_menu.js
Comment 1 by bugdroid1@chromium.org
, Mar 11 2016