Issue 593978 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	tbansal@chromium.org
Closed:	Mar 2016
Components:	Internals>Network>DataProxy
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Turn down lofi_active_control experiment policy

Project Member Reported by tbansal@chromium.org, Mar 11 2016

Issue description

This was added to collect CSI data from users that are in Lo-Fi control group, and have slow connection. We should remove this experiment, since we are moving to this new world where Chrome sets exp= header based on a separate finch trial (https://code.google.com/p/chromium/issues/detail?id=567804). Also, the data collected from CSI is similar to PLT UMA data, so there is no additional benefit from collecting CSI from Lo-Fi users.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6308dbaeb9ebe7bbfc3add19b509b6206d83f311

commit 6308dbaeb9ebe7bbfc3add19b509b6206d83f311
Author: tbansal <tbansal@chromium.org>
Date: Fri Mar 11 19:45:13 2016

Do not send lofi_active_control if the user is in the control
group.

BUG= 593978 

Review URL: https://codereview.chromium.org/1782313003

Cr-Commit-Position: refs/heads/master@{#380707}

[modify] https://crrev.com/6308dbaeb9ebe7bbfc3add19b509b6206d83f311/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[modify] https://crrev.com/6308dbaeb9ebe7bbfc3add19b509b6206d83f311/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/6308dbaeb9ebe7bbfc3add19b509b6206d83f311/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
[modify] https://crrev.com/6308dbaeb9ebe7bbfc3add19b509b6206d83f311/components/data_reduction_proxy/core/common/lofi_decider.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdad5571c40066599b9f790782607e83db6e10d8

commit fdad5571c40066599b9f790782607e83db6e10d8
Author: megjablon <megjablon@chromium.org>
Date: Wed Mar 16 05:29:34 2016

Remove unused chrome_proxy_lo_fi_experiment_directive()

BUG= 593978 

Review URL: https://codereview.chromium.org/1804163004

Cr-Commit-Position: refs/heads/master@{#381402}

[modify] https://crrev.com/fdad5571c40066599b9f790782607e83db6e10d8/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h

Comment 3 by tbansal@chromium.org, Mar 16 2016

Status: Fixed (was: Started)

►

Issue 593978 link

Issue metadata

Turn down lofi_active_control experiment policy

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 11 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

Comment 2 Deleted

Comment 3 by tbansal@chromium.org, Mar 16 2016

Comment 3 Deleted

Sign in to add a comment