New issue
Advanced search Search tips

Issue 593945 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gclient sync error updating windows build tools

Project Member Reported by noel@chromium.org, Mar 10 2016

Issue description

Updating today on Win7 cygwin, new compiler tool chain needed updating and has worked fine for past two months, wasn't expecting any error ...

________ running '/usr/bin/python src/build/landmines.py' in '/cygdrive/c/src/chrome'
Clobbering due to:
--- old_landmines       Tue Mar  8 01:15:48 2016
+++ new_landmines       Thu Mar 10 22:05:58 2016
@@ -3,3 +3 @@
-Switched win from VS2010 to VS2013.
-Update to VS2013 Update 2.
-Update to VS2013 Update 4.
+Switch to VS2015
Hook '/usr/bin/python src/build/landmines.py' took 122.55 secs

________ running '/usr/bin/python src/tools/remove_stale_pyc_files.py src/android_webview/tools src/build/android src/gpu/gles2_conform_support src/infra src/ppapi src/printing src/third_party/catapult src/third_party/closure_compiler/build src/tools' in '/cygdrive/c/src/chrome'

________ running '/usr/bin/python src/build/download_nacl_toolchains.py --mode nacl_core_sdk sync --extract' in '/cygdrive/c/src/chrome'

________ running '/usr/bin/python src/build/android/play_services/update.py download' in '/cygdrive/c/src/chrome'

________ running '/usr/bin/python src/build/linux/sysroot_scripts/install-sysroot.py --running-as-hook' in '/cygdrive/c/src/chrome'

________ running '/usr/bin/python src/build/vs_toolchain.py update' in '/cygdrive/c/src/chrome'
C:\Windows\Sysnative\ucrtbase.dll does not exist - installing Windows 10 Universal C Runtime
Running wusa.exe /quiet "C:\src\depot_tools\win_toolchain\vs_files\installers\Windows6.1-KB2999226-x64.msu"

--------------------------------------------------------------------------------

Elevation required. You must manually install this update:
  C:\src\depot_tools\win_toolchain\vs_files\installers\Windows6.1-KB2999226-x64.msu

--------------------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\src\depot_tools\win_toolchain\get_toolchain_if_necessary.py", line 435, in <module>
    sys.exit(main())
  File "C:\src\depot_tools\win_toolchain\get_toolchain_if_necessary.py", line 429, in main
    InstallUniversalCRTIfNeeded(abs_target_dir)
  File "C:\src\depot_tools\win_toolchain\get_toolchain_if_necessary.py", line 305, in InstallUniversalCRTIfNeeded
    installer)
Exception: Elevation required. You must manually install C:\src\depot_tools\win_toolchain\vs_files\installers\Windows6.1-KB2999226-x64.msu
Traceback (most recent call last):
  File "src/build/vs_toolchain.py", line 371, in <module>
    sys.exit(main())
  File "src/build/vs_toolchain.py", line 367, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "src/build/vs_toolchain.py", line 329, in Update
    subprocess.check_call(get_toolchain_args)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', '/cygdrive/c/src/depot_tools/win_toolchain/get_toolchain_if_necessary.py', '--output-json', '/cygdrive/c/src/chrome/src/build/win_toolchain.json', '391bbf1220d3edcd3cc3fccdb56224181e3b13a7', '--force']' returned non-zero exit status 1
Sending crash report ...
  [ crash report data snipped ]

Elevation required?  Win10 run-time on Win7?  Not sure how to proceed here.
 

Comment 1 by noel@chromium.org, Mar 10 2016

Summary: gclient sync error updating windows build tools (was: glcient sync error update windows build tools)

Comment 2 by noel@chromium.org, Mar 10 2016

https://codereview.chromium.org/1740583002 was reverted.

Tried gclient sync again .... and success, the runhooks stage worked fine.
That's curious. Overnight the default compiler on Windows was briefly changed to VS 2015. Also, there was a few week period when installing the Windows 10 Universal C Runtime was required, but that requirement was removed about a month ago. So, you *may* install that update, but you do not need to.

And, it is the Windows 7 version of the Windows 10 Universal C Runtime - it is actually designed for Windows 7.

In short, I'm not sure what happened.

Comment 4 by noel@chromium.org, Mar 11 2016

IC, I was updating overnight, but is ok again after the revert (#2), I can gclient sync, no errors.

I do have VS2013 Professional, Version 12.0.31101.00 Update 4, installed on my Win7 development boxes (came from go/stuff), if that might be relevant.
The only effect that the installer compiler has is that if you have VS 2015 installed then the UCRT will be there already - but that isn't required.

Here's my theory: your depot_tools has not updated in over a month. Go to depot_tools and try "git log -1 origin/master" and "git log -1" and see if you have recent changes in both places. If not then you'll need to investigate and fix that or else badness will occur.

Comment 6 by noel@chromium.org, Mar 11 2016

Your theory was correct.  I blew away my gclient, and re-installed it.  Let's close here unless you have more to add, and thank you for the help.
Status: WontFix (was: Untriaged)
There have been a few bugs that have caused depot_tools to stop updating. There are also lots of user-error ways to do this.

I'm glad the issue is resolved. I don't expect that it will hit other people, but if it does it is just revealing an underlying issue which they need to address anyway.

I'm closing as Won't Fix.

Sign in to add a comment