New issue
Advanced search Search tips

Issue 593920 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Turn down Mac Valgrind bots on memory.fyi

Project Member Reported by thestig@chromium.org, Mar 10 2016

Issue description

Mac Valgrind only runs on OS X 10.6, but Chromium no longer supports 10.6 as of M50, so 10.7+ features are creeping in and the Mac Valgrind bots are starting to fail. Time to throw in the towel.
 
Owner: benwells@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/482fbf6a38b085fff01d5ce0e4a3c554a9fbc308

commit 482fbf6a38b085fff01d5ce0e4a3c554a9fbc308
Author: benwells@chromium.org <benwells@chromium.org>
Date: Fri Mar 11 03:15:22 2016

Remove Mac Valgrind from the memory.fyi waterfall.

These bots require Mac OSX 10.6, which isn't supported by Chromium
anymore.

BUG= 593920 

Review URL: https://codereview.chromium.org/1781643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299241 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/482fbf6a38b085fff01d5ce0e4a3c554a9fbc308/masters/master.chromium.memory.fyi/master.cfg
[modify] https://crrev.com/482fbf6a38b085fff01d5ce0e4a3c554a9fbc308/masters/master.chromium.memory.fyi/notifier_cfg.py
[modify] https://crrev.com/482fbf6a38b085fff01d5ce0e4a3c554a9fbc308/masters/master.chromium.memory.fyi/slaves.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8464b0b4b8fcad7448f48a36bb6b73834a41830

commit d8464b0b4b8fcad7448f48a36bb6b73834a41830
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 07:35:39 2016

Removed mac valgrind test exclusions and suppressions.

The mac valgrind bot doesn't exist anymore, so no need for these
suppressions and exclusions.

BUG= 593920 

Review URL: https://codereview.chromium.org/1839303002

Cr-Commit-Position: refs/heads/master@{#383921}

[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/ipc_tests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/midi_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/net_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/remoting_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/safe_browsing_tests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/memcheck/suppressions_mac.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8464b0b4b8fcad7448f48a36bb6b73834a41830

commit d8464b0b4b8fcad7448f48a36bb6b73834a41830
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 07:35:39 2016

Removed mac valgrind test exclusions and suppressions.

The mac valgrind bot doesn't exist anymore, so no need for these
suppressions and exclusions.

BUG= 593920 

Review URL: https://codereview.chromium.org/1839303002

Cr-Commit-Position: refs/heads/master@{#383921}

[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/ipc_tests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/midi_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/net_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/remoting_unittests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/gtest_exclude/safe_browsing_tests.gtest_mac.txt
[delete] https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682/tools/valgrind/memcheck/suppressions_mac.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfc1fc6e71e1c98fb445fe1522181a1ce9a65b3a

commit cfc1fc6e71e1c98fb445fe1522181a1ce9a65b3a
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 22:02:49 2016

Remove references to mac valgrind bot.

The bot has been removed from the memory FYI waterfall.

BUG= 593920 

Review URL: https://codereview.chromium.org/1844493002

Cr-Commit-Position: refs/heads/master@{#384106}

[modify] https://crrev.com/cfc1fc6e71e1c98fb445fe1522181a1ce9a65b3a/PRESUBMIT_test.py
[modify] https://crrev.com/cfc1fc6e71e1c98fb445fe1522181a1ce9a65b3a/build/all.gyp

Status: Fixed (was: Assigned)
I think that's all of it...

Sign in to add a comment