New issue
Advanced search Search tips

Issue 593917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

emphasis-vertical.html, japanese-lr-selection.html, japanese-rl-selection.html are failing on WebKit Win10

Project Member Reported by alex...@chromium.org, Mar 10 2016

Issue description

The following tests:
  fast/writing-mode/japanese-rl-selection.html
  fast/text/emphasis-vertical.html
  fast/writing-mode/japanese-lr-selection.html

have all started failing consistently on WebKit Win10, starting with:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/7451

All three tests have non-trivial image diffs.

Blamelist: https://chromium.googlesource.com/chromium/src/+log/2782f0dd0af04e1bdc226938298d8a6957523f3a%5E..1ff345867aad0aab194da5acf8d46410f27d6494?pretty=fuller

Suspecting https://codereview.chromium.org/1754143002 - kojii@, mind taking a look?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8fd7a872697c3df6b76f65ad3f5d91119c921c6

commit d8fd7a872697c3df6b76f65ad3f5d91119c921c6
Author: alexmos <alexmos@chromium.org>
Date: Thu Mar 10 22:39:04 2016

Disable three failing layout tests for Win10.

The following tests are currently failing on Win10 with image diffs:
  fast/writing-mode/japanese-rl-selection.html
  fast/text/emphasis-vertical.html
  fast/writing-mode/japanese-lr-selection.html

BUG= 593917 
TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1786503002

Cr-Commit-Position: refs/heads/master@{#380480}

[modify] https://crrev.com/d8fd7a872697c3df6b76f65ad3f5d91119c921c6/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e603c9bfee03225f5212b1f576423d7fb264b2de

commit e603c9bfee03225f5212b1f576423d7fb264b2de
Author: kojii <kojii@chromium.org>
Date: Fri Mar 11 10:21:17 2016

Add lang="ja" to some Japanese tests to make results more sensible

This patch adds lang="ja" to 3 more tests that use Japanese text.

Han ideographic characters are rendered in Chinese fonts by default if
without the lang attribute on English Windows. By adding lang="ja",
they are rendered in Japanese fonts, and it makes the image results
closer to what users would see.

This was done to several tests in crbug.com/379189, but
crrev.com/380435 revealed there are 3 more.

BUG= 593917 ,  574660 

Review URL: https://codereview.chromium.org/1789493002

Cr-Commit-Position: refs/heads/master@{#380591}

[modify] https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de/third_party/WebKit/LayoutTests/fast/text/emphasis-vertical.html
[modify] https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de/third_party/WebKit/LayoutTests/fast/writing-mode/japanese-lr-selection.html
[modify] https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de/third_party/WebKit/LayoutTests/fast/writing-mode/japanese-rl-selection.html

Comment 3 by kojii@chromium.org, Mar 11 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1468804bebd13b91edfea4f8423b17f414f15bb6

commit 1468804bebd13b91edfea4f8423b17f414f15bb6
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Mar 14 18:26:04 2016

Auto-rebaseline for r380591

https://chromium.googlesource.com/chromium/src/+/e603c9bfe

BUG= 593917 
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1799813002 .

Cr-Commit-Position: refs/heads/master@{#381018}

[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-vertical-expected.png
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-vertical-expected.txt
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/text/emphasis-vertical-expected.png
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/text/emphasis-vertical-expected.txt
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/japanese-lr-selection-expected.png
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/japanese-lr-selection-expected.txt
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/japanese-rl-selection-expected.png
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/japanese-rl-selection-expected.txt
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win7/fast/text/emphasis-vertical-expected.png
[modify] https://crrev.com/1468804bebd13b91edfea4f8423b17f414f15bb6/third_party/WebKit/LayoutTests/platform/win7/fast/text/emphasis-vertical-expected.txt

Sign in to add a comment