New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593910 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove commit_all_working_directory_changes from scm/git api.

Project Member Reported by wkorman@chromium.org, Mar 10 2016

Issue description

Breakout from http://crrev.com/1784923002

...only the auto-rebaseline command tries to commit things these days, so we should probably make commit_all_working_directory_changes=True unconditionally and require the author (and just have the command pass in $USER or `git config -l user.name` if it isn't specified)
 
dpranke@ -- there is one remaining use of commit_all_working_directory_changes=False in the layout_tests_mover.py script:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover.py&q=commit_all_working_directory_changes&sq=package:chromium&dr=C&l=302

Is this script obsolete? Or, we can revise this script to behave similarly to auto-rebaseline and bail with an error if there are local uncommitted changes.
Cc: ojan@chromium.org
I've never used this script, and I don't think we've really used it anywhere else, either. It was created in  bug 227324 , so I guess you could see if Ojan thinks we should keep it around.

Personally, I'd delete it and, failing that, would be fine with it moving the files but not actually committing the changes, too.
Status: Fixed (was: Assigned)

Comment 5 by sshru...@google.com, Mar 18 2016

Components: -Blink>Tools>Test Blink>ToolsTest
Fixing component name after Monorail migration

Comment 6 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra

Sign in to add a comment