New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

fast/dom/htmlcollection-reachable.html is timing out on WebKit Linux (dbg)

Project Member Reported by alex...@chromium.org, Mar 10 2016

Issue description

fast/dom/htmlcollection-reachable.html has been consistently timing out on WebKit Linux (dbg) since this build:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/6384

Blamelist: https://chromium.googlesource.com/chromium/src/+log/c35b5f82886c220e05a1b0fec8e570eb24d1930d%5E..764e6bb1b05458cde3ca0702ceb801d25c3dcc3b

I'm not sure which CL might have caused this, but CC-ing tkent@ and haraken@ who have some Blink changes in the list.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc6196e756ee87afda1b177f74a1e82f2c027dac

commit bc6196e756ee87afda1b177f74a1e82f2c027dac
Author: alexmos <alexmos@chromium.org>
Date: Thu Mar 10 21:17:47 2016

Disable fast/dom/htmlcollection-reachable.html on Linux

BUG= 593888 
TBR=tkent@chromium.org,haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1782743004

Cr-Commit-Position: refs/heads/master@{#380465}

[modify] https://crrev.com/bc6196e756ee87afda1b177f74a1e82f2c027dac/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>LayoutTests
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88208d23d8a1955d762e32127a23255476f4082a

commit 88208d23d8a1955d762e32127a23255476f4082a
Author: alexmos <alexmos@chromium.org>
Date: Thu Mar 10 23:34:00 2016

Fix fast/dom/htmlcollection-reachable.html timeout expectation to be debug only.

BUG= 593888 
NOTRY=true

Review URL: https://codereview.chromium.org/1785883002

Cr-Commit-Position: refs/heads/master@{#380491}

[modify] https://crrev.com/88208d23d8a1955d762e32127a23255476f4082a/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by tkent@chromium.org, Mar 11 2016

Cc: -tkent@chromium.org
Components: Blink>MemoryAllocator>GarbageCollection Blink>HTML
It seems the test has been flaky at latest since Feb 28.  Probably it's getting slower and slower.
This might be GC-related issue.  The test calls gc() multiple times.


Cc: oilpan-reviews@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, May 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb30081090c3906aa2c50d5b7b9f57b7987b24e

commit fcb30081090c3906aa2c50d5b7b9f57b7987b24e
Author: sigbjornf <sigbjornf@opera.com>
Date: Sun May 01 21:52:44 2016

Have htmlcollection-reachable.html force the one GC needed.

Calling window.gc() slows down test running times, and is
preferably avoided unless needed to verify behavior across
a GC.

For htmlcollection-reachable.html, we only need the
one GC to determine liveness of custom properties for
various platform objects across a garbage collection.

R=
BUG= 593888 

Review-Url: https://codereview.chromium.org/1934183002
Cr-Commit-Position: refs/heads/master@{#390872}

[modify] https://crrev.com/fcb30081090c3906aa2c50d5b7b9f57b7987b24e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fcb30081090c3906aa2c50d5b7b9f57b7987b24e/third_party/WebKit/LayoutTests/fast/dom/htmlcollection-reachable-expected.txt
[modify] https://crrev.com/fcb30081090c3906aa2c50d5b7b9f57b7987b24e/third_party/WebKit/LayoutTests/fast/dom/htmlcollection-reachable.html

Owner: sigbjo...@opera.com
Status: Fixed (was: Available)

Comment 9 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Sign in to add a comment