New issue
Advanced search Search tips

Issue 593887 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility

Blocked on:
issue 634233
issue 676447
issue 676448
issue 676449
issue 676450
issue 676451
issue 699617
issue 706976
issue 707639



Sign in to add a comment

Chrome OS accessibility: select to speak

Project Member Reported by dmazz...@chromium.org, Mar 10 2016

Issue description

There are already a few extensions that attempt to do this, but we can build something far more robust and clean using the automation API.

The goal is an accessibility feature that makes it easy for users to click or tap on anything and have it speak.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756089a218696542cadcf96a1a7ed00025c1f255

commit 756089a218696542cadcf96a1a7ed00025c1f255
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Mar 15 23:55:16 2016

Add 5 experimental accessibility features on Chrome OS.

This just adds the boilerplate for five new accessibility features and hides
them behind a flag. All five have been prototyped and are ready for
implementation.

The first three are related, they just provide visual highlighting to
help low-vision users keep track of things on the screen:
* Caret highlight
* Cursor highlight
* Focus highlight

Hold down a key and click or drag to speak any visible text on screen
* Select to speak

Control the whole computer with a single switch (for motor impaired users)
* Switch access

For now, there's no need to put these in the tray. They can graduate to the
tray when they launch.

BUG= 314889 , 593887 ,593885

Review URL: https://codereview.chromium.org/1785833002

Cr-Commit-Position: refs/heads/master@{#381353}

[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/ash/accessibility_delegate.h
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/ash/default_accessibility_delegate.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/ash/default_accessibility_delegate.h
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/about_flags.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/ui/ash/chrome_shell_delegate_views.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/common/extensions/api/accessibility_features.json
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/common/extensions/api/chromeos_info_private.json
[add] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/common/extensions/docs/templates/intros/accessibilityFeatures.html
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/common/pref_names.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chrome/common/pref_names.h
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chromeos/chromeos_switches.cc
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/chromeos/chromeos_switches.h
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/tools/metrics/actions/actions.xml
[modify] https://crrev.com/756089a218696542cadcf96a1a7ed00025c1f255/tools/metrics/histograms/histograms.xml

Owner: dmazz...@chromium.org
Status: Started (was: Available)
Blockedon: 634233
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5288b26171229540116cc44b3505a28f051b5ffc

commit 5288b26171229540116cc44b3505a28f051b5ffc
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Sep 16 23:05:39 2016

Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG= 593887 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2216433004
Cr-Commit-Position: refs/heads/master@{#419318}

[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/BUILD.gn
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[add] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/chromevox/run_jsbundler.gni
[add] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[add] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/select_to_speak/OWNERS
[add] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/select_to_speak/background.js
[add] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc/chrome/common/extensions/extension_constants.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/735c79df7859362bd059b5c233286910eff25ef9

commit 735c79df7859362bd059b5c233286910eff25ef9
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Nov 28 22:39:42 2016

Select-to-speak event handler

This change implements the key C++ portion of the Select-to-speak feature
by adding an event handler that takes Search plus the mouse button, and
fires accessibility events instead.

In the future we could modify or extend this event handler for use in
ChromeVox too, but for now I think building something specifically for
Select-to-speak makes sense.

Adds new accessibility events for mouse down, mouse up, and so on - allowing
the select-to-speak extension to get not only the mouse events and global
coordinates, but most importantly the proper accessibility object that's hit
for each event.

This change implements support for hit testing in Views. For web,
the extension will get the event fired on the views::WebView and it can do
its own hit testing within the accessibility tree from there. A follow-up
will improve on this by doing native hit testing in the web before firing
the accessibility event.

BUG= 593887 

Review-Url: https://codereview.chromium.org/2493923002
Cr-Commit-Position: refs/heads/master@{#434744}

[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_environment.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_environment_content.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_environment_content.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_environment_default.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_helper.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_views_delegate.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ash/test/ash_test_views_delegate.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/accessibility/accessibility_manager.h
[add] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
[add] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h
[add] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/test/base/ash_test_environment_chrome.cc
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/chrome/test/base/ash_test_environment_chrome.h
[modify] https://crrev.com/735c79df7859362bd059b5c233286910eff25ef9/ui/accessibility/ax_enums.idl

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2

commit e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Dec 01 05:03:09 2016

Select-to-speak extension code

This is an initial implementation of Select-to-speak. Given mouse events
that are "captured" - currently by holding down Search - it draws a box
around the area the user selects, and then speaks everything within that
box based on its accessible name.

This is not meant to be a final, complete implementation, just a good
starting point to begin experimenting.

Depends on: https://codereview.chromium.org/2493923002/

BUG= 593887 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509883002
Cr-Commit-Position: refs/heads/master@{#435555}

[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/chromevox/common/compiled_resources2.gyp
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[delete] https://crrev.com/f05a6730ca4ecdfe336276f0f96d33c2aeb028be/chrome/browser/resources/chromeos/select_to_speak/background.js
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_unittest.gtestjs
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/browser/resources/chromeos/select_to_speak/test_support.js
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/chrome/test/BUILD.gn
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/third_party/closure_compiler/compiled_resources2.gyp
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/third_party/closure_compiler/externs/accessibility_private.js
[add] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/e6dd62f781641b4fa8e19d38f2ed04547ee5f4a2/third_party/closure_compiler/externs/compiled_resources2.gyp

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e25a7de67ab94077def5f8f9b7672ca72f46070

commit 1e25a7de67ab94077def5f8f9b7672ca72f46070
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Dec 08 17:38:52 2016

Chrome OS select-to-speak feature not properly handling key repeat

The select-to-speak feature is triggered when holding down the Search
key and clicking or dragging. Holding down Search generates additional
key press events due to key repeat, which was resetting the state in
the middle of a drag. Fix this and add a test.

BUG= 593887 

Review-Url: https://codereview.chromium.org/2558903002
Cr-Commit-Position: refs/heads/master@{#437275}

[modify] https://crrev.com/1e25a7de67ab94077def5f8f9b7672ca72f46070/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
[modify] https://crrev.com/1e25a7de67ab94077def5f8f9b7672ca72f46070/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc

Blockedon: 676447 676448 676449 676450 676451
Blockedon: 699617
Labels: NewComponent-Accessibility NewComponent-Accessibility-ChromeVox
Labels: -NewComponent-Accessibility-ChromeVox NewComponent-Accessibility-Features
Blockedon: 706976
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27

commit 259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Mar 31 07:48:21 2017

Add i18n support to Select-to-speak

BUG= 593887 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775303004
Cr-Commit-Position: refs/heads/master@{#461071}

[modify] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[modify] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/BUILD.gn
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_am.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ar.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_bg.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_bn.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ca.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_cs.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_da.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_de.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_el.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_en-GB.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_es-419.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_es.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_et.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fa.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fi.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fil.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fr.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_gu.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_hi.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_hr.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_hu.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_id.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_it.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_iw.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ja.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_kn.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ko.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_lt.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_lv.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ml.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_mr.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ms.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_nl.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_no.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_pl.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_pt-BR.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_pt-PT.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ro.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ru.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_sk.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_sl.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_sr.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_sv.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_sw.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_ta.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_te.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_th.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_tr.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_uk.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_vi.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_zh-CN.xtb
[add] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_zh-TW.xtb
[modify] https://crrev.com/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27/tools/gritsettings/translation_expectations.pyl

Blockedon: 707639
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0672582d53d0b7f561d129e28a30d5ae5cf28605

commit 0672582d53d0b7f561d129e28a30d5ae5cf28605
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Apr 03 19:22:40 2017

Add a color argument to accessibilityPrivate.setFocusRing

We're using the focus ring highlighting for multiple purposes now, this
gives us a way to use a different color for each one, or maybe make it a
user preference.

BUG= 593887 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2789583004
Cr-Commit-Position: refs/heads/master@{#461499}

[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/chromeos/ui/focus_ring_layer.cc
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/chromeos/ui/focus_ring_layer.h
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/chrome/common/extensions/api/accessibility_private.json
[modify] https://crrev.com/0672582d53d0b7f561d129e28a30d5ae5cf28605/third_party/closure_compiler/externs/accessibility_private.js

Labels: -newcomponent-accessibility -newcomponent-accessibility-features
Status: Fixed (was: Started)
Closing this master bug now that this has launched. Lots of smaller bugs are now open.

Comment 21 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 22 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment