New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593850 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Stylus tilt info seems lost on ChromeOS

Project Member Reported by mustaq@chromium.org, Mar 10 2016

Issue description

Just discovered that in 50.0.2657.0, stylus tilt data is not reaching JS anymore!

The "pressure" and "pointerType" fields seem working fine.
http://patrickhlauke.github.io/touch/pen-tracker/

I believe this could be a CrOS level bug because ToT Android build still reports tilt.
 

Comment 1 by mustaq@chromium.org, Mar 10 2016

Owner: mustaq@chromium.org
Status: Assigned (was: Available)
Amir/Michael, are you aware of any low-level change?
Cc: -spang@chromium.org adlr@chromium.org
adlr@, any idea what changed? I vaguely remember hearing that CrOS may start treating on-screen vs off-screen stylus differently. Any chance this change has taken place already?

- Just confirmed that evtest is showing stylus tilt info from Wacom Intuos Pro. Not sure where it is getting lost. Tested again on Chrome ToT on CrOS (52.0.2723.0), the regression is still there.

- Forgot to mention before: need to enable PointerEvents though about:flags for the repro.

Cc: nzolghadr@chromium.org

Comment 4 by adlr@chromium.org, Jun 1 2016

Is this an issue in pointer events?
The outcome we are seeing is through PointerEvents but the regression could be anywhere in the pipeline after device driver (evtest still works).

Nothing changed in event property plumbing in Blink I believe. Don't know what caused it: chromium or some CrOS specific code.

Comment 6 by adlr@chromium.org, Jun 1 2016

Does anyone own the input code in Chrome for Chrome OS/linux?
Cc: spang@chromium.org
Michael, any chance you know the answer to #6?

Comment 8 by spang@chromium.org, Jun 3 2016

No full time owner, no, but the code is in maintenance mode so such a person would probably get bored.

I'm not aware of nay changes that could cause this. Mustaq, since nobody has a guess as to the cause, could you bisect to find the culprit CL?
Status: Started (was: Assigned)
Looking into it.
Ooops, looks like a crack in Blink code, in PointerEventFactory to be precise!

Labels: Hotlist-Fixit-PE2016
Labels: Merge-Request-52 M-52

Comment 14 by tin...@google.com, Jun 10 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 10 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81cc368082725d36a267ffbe37f2eb96e7585551

commit 81cc368082725d36a267ffbe37f2eb96e7585551
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri Jun 10 16:58:11 2016

Added missing pen tilt when creating PointerEvent from ME.

Added back the missing plumbing. Also added EventSender support to pass stylus
info for testing.

BUG= 593850 

Review-Url: https://codereview.chromium.org/2043053002
Cr-Commit-Position: refs/heads/master@{#398933}
(cherry picked from commit abca6ff6e9ffb9791242701d4499e0144ed94283)

Review URL: https://codereview.chromium.org/2054123002 .

Cr-Commit-Position: refs/branch-heads/2743@{#316}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/components/test_runner/event_sender.cc
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/components/test_runner/event_sender.h
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81cc368082725d36a267ffbe37f2eb96e7585551

commit 81cc368082725d36a267ffbe37f2eb96e7585551
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri Jun 10 16:58:11 2016

Added missing pen tilt when creating PointerEvent from ME.

Added back the missing plumbing. Also added EventSender support to pass stylus
info for testing.

BUG= 593850 

Review-Url: https://codereview.chromium.org/2043053002
Cr-Commit-Position: refs/heads/master@{#398933}
(cherry picked from commit abca6ff6e9ffb9791242701d4499e0144ed94283)

Review URL: https://codereview.chromium.org/2054123002 .

Cr-Commit-Position: refs/branch-heads/2743@{#316}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/components/test_runner/event_sender.cc
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/components/test_runner/event_sender.h
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/81cc368082725d36a267ffbe37f2eb96e7585551/third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Cc: tdres...@chromium.org lanwei@chromium.org
 Issue 624815  has been merged into this issue.
Labels: VerifyIn-55

Comment 21 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 22 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 23 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 24 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 25 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 27 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment