New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Sheriffbot-Auto-triage Rule: Needs-Feedback and unconfirmed bugs which are not modified for 30 days when feedback is received

Project Member Reported by rsleevi@chromium.org, Mar 10 2016

Issue description

Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago.


Add Bug number which got updated:
https://bugs.chromium.org/p/chromium/issues/detail?id=570278

Issue/Concern or feedback:
Feedback wasn't received; it was a friendly ping by a Network team member doing triage to remind the user to submit feedback. It would seem the SheriffBot treats pings for details (which can be helpful to remind users) as feedback itself. If SheriffBot did the pings, this wouldn't be necessary.

Any other important details:
I suspect that because we had to reset the flags, SheriffBot's timer for auto-closing is now reset. If there was a way to set the countdown timer at a particular value (e.g. what it was before the mis-triage), that would help remedy situations when the bot logic fails.
 
Summary: Sheriffbot-Auto-triage Rule: Needs-Feedback and unconfirmed bugs which are not modified for 30 days when feedback is received (was: Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago)
Sorry, clicked wrong short-link

Comment 2 by gov...@chromium.org, Mar 10 2016

Related  bug 593390 

Comment 3 by gov...@chromium.org, Mar 10 2016

Cc: mbarbe...@chromium.org

Comment 4 by gov...@chromium.org, Mar 14 2016

Owner: cda...@chromium.org

Comment 5 by cda...@chromium.org, Mar 14 2016

Thanks for the feedback (there was a bug in our part for not catching feedback pings when asked again for feedback. now we fixed this)

Thanks

Comment 6 by cda...@chromium.org, Mar 17 2016

Cc: -lafo...@chromium.org ananthak@chromium.org gov...@chromium.org
Owner: lafo...@chromium.org
I think we should also address when there is an activity after "Needs Feedback" label added but not from the reporter.
example there might be cases when.
1.Reporter gives feedback from a different account other than the reported.
2.Some other user gives the required Feedback.
3.Dev or Tester who is working on it might have found the problem but forgot to remove the "Needs-Feedback" label.

Assiging to Anthony for further input to proceed.
Unless I'm missing something,  tata0730@ didn't respond after the last Needs-Feedback warning (comment #22), which occurred after the developer was threatening to automatically close the bug in the absence of feedback (comment #23)... which is consistent w/ the intent of the logic (i.e. to auto-close non-responses from the reporter, which is the common case).

Comment #24 (i.e. the assignment) strikes me as being different than what I'd expect, since no response was given after the Needs-Feedback label was applied.  I'd have expected the bug to be closed at that point.

Comment 8 by cda...@chromium.org, Mar 18 2016

Affected bug  https://bugs.chromium.org/p/chromium/issues/detail?id=586080 [ Where User gave feedback from different account.]

It's unclear to me that that would be the common case, it seems unusual that people would rotate accounts.

Even for those cases, the "Please re-open or file a new bug if this is still an issue." provides a reasonable escape hatch for the filer.

Perhaps we could change the wording to "No feedback was received from the reporter (....)," so that it's un-ambiguous why we are closing the issue.  So long as the application of the rule is clear, most people won't begrudge a bot. 
Cc: -cda...@chromium.org lafo...@chromium.org
Owner: cda...@chromium.org
Thanks Anthony for clarifying. i'll add "No feedback was received from the reporter (....)," to our comment.
I've added "No feedback was received from the reporter (....)," to the comment
Status: Fixed (was: Assigned)
Below changes made to this rule. so marking this bug as fixed.

When no feedback received:
1."No feedback was received from the reporter (....)," added to comment.

When feedback is received:
if owner not present: then add the "Needs-Feedback" requester as owner. No status changed. 

if already has a owner (provided the owner is not the reporter) then ignore setting the owner. Status not changed.

Along with that remove "Needs-Feedback" label and add "Needs-Review" for tracking.

More details are found in  issue 596470 


Sign in to add a comment