New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593822 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
█ vpalatin@chromium.org
█ rachelsn@chromium.org
█ kevin.k....@intel.com
█ sha...@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

cros-ec: support multiple TCPC drivers on the same board

Project Member Reported by sha...@chromium.org, Mar 10 2016 
We're currently calling into TCPC driver functions (eg. tcpc_alert()) directly, so we can't add multiple TCPC drivers without creating linker errors. We should create a driver struct for each TCPC driver with the necessary callback function pointers, and add the correct struct to tcpc_config_t, based upon the actual TCPC assigned to a given port.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b

commit b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b
Author: Kevin K Wong <kevin.k.wong@intel.com>
Date: Wed Mar 30 01:24:24 2016

tcpm: update code to support multiple tcpm driver

BUG= chromium:593822 
BRANCH=none
TEST=make buildall

Change-Id: Ic30c1b890da7639aa80a53040ecc5bebfb4be2e8
Signed-off-by: Kevin K Wong <kevin.k.wong@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/336030
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/elm/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/common/usb_pd_protocol.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/fusb302.h
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/tcpci.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/include/usb_pd_tcpm.h
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/fusb302.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/common/host_command_pd.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/strago/board.h
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/stub.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/chell/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/kunimitsu/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/strago/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/pdeval-stm32f072/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/tcpci.h
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/common/usb_pd_tcpc.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/snoball/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/oak/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/glados/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/lars/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/driver/tcpm/tcpm.h
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/wheatley/board.c
[modify] https://crrev.com/b10d12f1c95fa6c13c83f1da34bbaf21063d9a2b/board/kevin/board.c

Comment 2 by gkihumba@google.com, Apr 7 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment