New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593797 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add metrics for the usage of 'Cast…' app menu item on desktop

Project Member Reported by edwardjung@chromium.org, Mar 10 2016

Issue description

The 'Cast…' menu item was recently introduced to the app menu. There doesn't seem to be metrics added for this Cast item. Could this be implemented. 

Chrome UX added usage and time to action metrics to all the menu items to understand usage and inform placement of menu items and we would like keep track of the Cast menu item. 

Update the AppMenuAction enum
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/toolbar/app_menu_model.h&l=30

Add a corresponding entry to the 'WretchMenuAction' enum in histograms.xml
Add an extra case in AppMenuModel::LogMenuMetrics
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/toolbar/app_menu_model.cc&sq=package:chromium&type=cs&l=384

Thanks.

 
Cc: ainslie@chromium.org
Components: Blink>PresentationAPI
Cc: -apaci...@chromium.org imch...@chromium.org
Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c96faa3bf8ca74c0173b8cfc88894c69063cf100

commit c96faa3bf8ca74c0173b8cfc88894c69063cf100
Author: apacible <apacible@chromium.org>
Date: Fri Mar 11 18:27:38 2016

Add UMA metrics for "Cast..." menu item.

This change adds the following metrics:
- Time between the user opening the menu and clicking the "Cast..." item.
- Number of times the "Cast..." item is clicked.

BUG= 593797 

Review URL: https://codereview.chromium.org/1786453002

Cr-Commit-Position: refs/heads/master@{#380676}

[modify] https://crrev.com/c96faa3bf8ca74c0173b8cfc88894c69063cf100/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/c96faa3bf8ca74c0173b8cfc88894c69063cf100/chrome/browser/ui/toolbar/app_menu_model.h
[modify] https://crrev.com/c96faa3bf8ca74c0173b8cfc88894c69063cf100/tools/metrics/histograms/histograms.xml

Cc: sko...@chromium.org
Status: Fixed (was: Started)
It would be a good idea to get this into M50 so we can start gathering metrics. I'll request a merge after it runs through Canary.

Sign in to add a comment