New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593793 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Port v8 metrics to javascript (TBM 2.0)

Project Member Reported by nedngu...@google.com, Mar 10 2016

Issue description

Now that TBM 2.0 framework is established, we need to port v8 metrics to javascript to get more detailed analysis: v8 metrics during page load time, etc...

I assign this to cbruni@ since this was in our plan since last time.
 
Blocking: -583399
Cc: eakuefner@chromium.org

Comment 3 by cbruni@chromium.org, Mar 11 2016

I am really eager to push this further to make sure our use-case will work properly in TBM v2.0.

Can you point me to some documents and examples on how to implement and run the new metrics?
Here's an example benchmark:
https://github.com/catapult-project/catapult/blob/master/telemetry/examples/benchmarks/tbm_benchmark.py

and the metric it uses:
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/sample_metric.html

For a more substantive benchmark/metric pair, see Ben's CL and the CL it references in the description: https://codereview.chromium.org/1741843002

In addition to running the metric through Telemetry, you can also use catapult/tracing/bin/run_metric to run a metric on a trace or directory of traces.

Finally our design doc, with a link to some brainstorm notes which used V8 as an example use case towards the bottom:
https://docs.google.com/document/d/1LJbh9iF7e18jNEDwD_tYt5WtiOoMJdV12Z9GxdTLJUo/edit#

Camillo, please reach out to me if you have questions about any of this stuff.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5800dfe3f534cd97ff433501b3e45c56831d2f2b

commit 5800dfe3f534cd97ff433501b3e45c56831d2f2b
Author: jochen <jochen@chromium.org>
Date: Wed Apr 06 04:09:18 2016

Upgrade v8.todomvc{,-ignition} to TBMv2

BUG= 593406 , 593793 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1857613002

Cr-Commit-Position: refs/heads/master@{#385381}

[modify] https://crrev.com/5800dfe3f534cd97ff433501b3e45c56831d2f2b/tools/perf/benchmarks/v8.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11e64d6d75e8d7c5100ee36f9a8d26831affcd2b

commit 11e64d6d75e8d7c5100ee36f9a8d26831affcd2b
Author: hablich <hablich@chromium.org>
Date: Thu Apr 14 16:15:26 2016

[Benchmark] Upgrade v8.google to TBMv2

BUG=chromium:517805, chromium:593793 
R=cbruni@chromium.org,nednguyen@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1884163002

Cr-Commit-Position: refs/heads/master@{#387331}

[modify] https://crrev.com/11e64d6d75e8d7c5100ee36f9a8d26831affcd2b/tools/perf/benchmarks/v8.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a791019658bc90c48afb894f3481952ac403c5f

commit 0a791019658bc90c48afb894f3481952ac403c5f
Author: cbruni <cbruni@chromium.org>
Date: Mon Apr 18 16:02:07 2016

[perf] Add speedometer-ignition benchmark

BUG= chromium:593793 
LOG=n
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1860013002

Cr-Commit-Position: refs/heads/master@{#387921}

[modify] https://crrev.com/0a791019658bc90c48afb894f3481952ac403c5f/tools/perf/benchmarks/speedometer.py
[modify] https://crrev.com/0a791019658bc90c48afb894f3481952ac403c5f/tools/perf/benchmarks/v8.py
[add] https://crrev.com/0a791019658bc90c48afb894f3481952ac403c5f/tools/perf/benchmarks/v8_helper.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdad752ea557a7be1c2d39cfefcf05a6b643c59e

commit fdad752ea557a7be1c2d39cfefcf05a6b643c59e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Apr 19 23:33:20 2016

Roll src/third_party/catapult/ 8acb96699..a39f24c16 (14 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8acb96699511..a39f24c16d2f

$ git log 8acb96699..a39f24c16 --date=short --no-merges --format='%ad %ae %s'

BUG= 352807 , 593793 

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1898343002

Cr-Commit-Position: refs/heads/master@{#388355}

[modify] https://crrev.com/fdad752ea557a7be1c2d39cfefcf05a6b643c59e/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5e117377ac5972212f844b60cf688a01723137e

commit c5e117377ac5972212f844b60cf688a01723137e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Apr 27 12:38:34 2016

Roll src/third_party/catapult/ 33a2e30c0..b26a0cbf1 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/33a2e30c0e1b..b26a0cbf1935

$ git log 33a2e30c0..b26a0cbf1 --date=short --no-merges --format='%ad %ae %s'

BUG= 593793 

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1923643003

Cr-Commit-Position: refs/heads/master@{#390052}

[modify] https://crrev.com/c5e117377ac5972212f844b60cf688a01723137e/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4062007996923a8951e5181134f0c6f13793cd9

commit b4062007996923a8951e5181134f0c6f13793cd9
Author: ulan <ulan@chromium.org>
Date: Thu Apr 28 19:06:08 2016

Port memory.long_running_idle_gmail benchmarks to TBMv2.

This replaces:
memory.long_running_idle_gmail_tbm with
memory.long_running_idle_gmail_tbmv2
and
memory.long_running_idle_gmail_background with
memory.long_running_idle_gmail_background_tbmv2

BUG= chromium:593793 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1931533002
Cr-Commit-Position: refs/heads/master@{#390441}

[modify] https://crrev.com/b4062007996923a8951e5181134f0c6f13793cd9/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/b4062007996923a8951e5181134f0c6f13793cd9/tools/perf/benchmarks/memory_infra.py
[modify] https://crrev.com/b4062007996923a8951e5181134f0c6f13793cd9/tools/perf/page_sets/long_running_idle_google_cases.py

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d11e43b2d31b519408b0a78528648528a91f5e

commit 48d11e43b2d31b519408b0a78528648528a91f5e
Author: ulan <ulan@chromium.org>
Date: Fri Apr 29 14:29:44 2016

Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2.

BUG= 593793 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1924523002
Cr-Commit-Position: refs/heads/master@{#390645}

[modify] https://crrev.com/48d11e43b2d31b519408b0a78528648528a91f5e/tools/perf/benchmarks/v8.py

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c5f1659cf7b36e1517d41652deccde340fc570

commit a2c5f1659cf7b36e1517d41652deccde340fc570
Author: simonhatch <simonhatch@chromium.org>
Date: Fri Apr 29 15:32:08 2016

Revert of Port memory.long_running_idle_gmail benchmarks to TBMv2. (patchset #6 id:100001 of https://codereview.chromium.org/1931533002/ )

Reason for revert:
All the windows bots going purple, suspect this CL.

BUG= 607922 

Original issue's description:
> Port memory.long_running_idle_gmail benchmarks to TBMv2.
>
> This replaces:
> memory.long_running_idle_gmail_tbm with
> memory.long_running_idle_gmail_tbmv2
> and
> memory.long_running_idle_gmail_background with
> memory.long_running_idle_gmail_background_tbmv2
>
>
> BUG= chromium:593793 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

TBR=nednguyen@google.com,petrcermak@chromium.org,perezju@chromium.org,ulan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:593793 

Review-Url: https://codereview.chromium.org/1935493003
Cr-Commit-Position: refs/heads/master@{#390656}

[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/benchmarks/memory_infra.py
[modify] https://crrev.com/a2c5f1659cf7b36e1517d41652deccde340fc570/tools/perf/page_sets/long_running_idle_google_cases.py

Project Member

Comment 13 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449

commit 5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449
Author: ulan <ulan@chromium.org>
Date: Tue May 03 12:04:20 2016

Reland of Port memory.long_running_idle_gmail benchmarks to TBMv2.

The windows bots going purple should be fixed by
https://codereview.chromium.org/1935593002/

This replaces:
memory.long_running_idle_gmail_tbm with
memory.long_running_idle_gmail_tbmv2
and
memory.long_running_idle_gmail_background with
memory.long_running_idle_gmail_background_tbmv2

BUG= 607922 , 593793 
TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1938923002
Cr-Commit-Position: refs/heads/master@{#391205}

[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/benchmarks/memory_infra.py
[modify] https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449/tools/perf/page_sets/long_running_idle_google_cases.py

Status: Fixed (was: Assigned)

Sign in to add a comment