New issue
Advanced search Search tips

Issue 593791 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 347322



Sign in to add a comment

Autotest: tpm_dam.get_dictionary_attack_counter break cryptohome fio test

Project Member Reported by gwendal@chromium.org, Mar 10 2016

Issue description

tpm_dam.get_dictionary_attack_counter() stops and restarts several services, including cryptohomed to retrieve TPM information.

The serivces are restarted, but they are not fully operational when the next test needs them:

...
03/09 16:04:39.551 DEBUG|        base_utils:0177| Running 'stop cryptohomed'
...
03/09 16:30:01.466 DEBUG|        base_utils:0177| Running 'tpmc raw 00 c1 00 00 00 16 00 00 00 ...
...
03/09 16:30:01.994 DEBUG|        base_utils:0177| Running 'start cryptohomed'
03/09 16:30:02.049 DEBUG|        base_utils:0268| [stdout] cryptohomed start/running, process 642
03/09 16:30:02.106 INFO |               job:0210|               GOOD    platform_CryptohomeFio.seq_write        platform_CryptohomeFio.seq_write        timestamp=1457569802    localtime=Mar 09 16:30:02       completed successfully
03/09 16:30:02.165 INFO |               job:0210|       END GOOD        platform_CryptohomeFio.seq_write        platform_CryptohomeFio.seq_write        timestamp=1457569802    localtime=Mar 09 16:30:02
...
03/09 16:30:02.376 INFO |               job:0210|       START   platform_CryptohomeFio.8k_write platform_CryptohomeFio.8k_write timestamp=1457569802    localtime=Mar 09 16:30:02
...
03/09 16:30:02.703 DEBUG|        base_utils:0177| Running '/usr/sbin/cryptohome --action=mount --user=test@chromium.org --password=test --create 2>&1'
03/09 16:30:02.756 DEBUG|        base_utils:0268| [stdout] [ERROR:cryptohome.cc(222)] GetSystemSalt failed: The name org.chromium.Cryptohome was not provided by any .service files
03/09 16:30:02.757 DEBUG|        base_utils:0268| [stdout] Mount call failed: The name org.chromium.Cryptohome was not provided by any .service files, with reason code: 0.
03/09 16:30:02.758 DEBUG|        base_utils:0268| [stdout] Mount failed.
03/09 16:30:02.759 INFO |        cryptohome:0206| [ERROR:cryptohome.cc(222)] GetSystemSalt failed: The name org.chromium.Cryptohome was not provided by any .service files


The fix might just be to add a delay after restarting cryptohomed to be sure it is working.

I saw similar issue during the diskqual [

 

Comment 1 by snanda@chromium.org, Jan 26 2017

Cc: apronin@chromium.org gwendal@chromium.org
Owner: asavery@chromium.org
Lets put in a retry for cryptohomed to come back up.
Cc: akes...@chromium.org xixuan@chromium.org
 Issue 658943  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ccb16be83172c3f10c421a0a6eb582f1bed359e0

commit ccb16be83172c3f10c421a0a6eb582f1bed359e0
Author: Alexis Savery <asavery@chromium.org>
Date: Sat Feb 25 18:32:07 2017

autotest: Add retry loop to mount_vault

Add retry loop to mount_vault to allow cryptohomed enough time to
restart.

BUG= chromium:593791 
TEST=Ran platform_CryptohomeFio.stress and all tests pass, some
retry mounting up to 4 times and then continue as expected.

Change-Id: If0043435e120bca347ad0615065db1ad7ed40697
Reviewed-on: https://chromium-review.googlesource.com/435946
Commit-Ready: Alexis Savery <asavery@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/ccb16be83172c3f10c421a0a6eb582f1bed359e0/client/cros/cryptohome.py

Status: Assigned (was: Untriaged)
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
Components: OS>Systems>Security
Status: Fixed (was: Assigned)
IIUC this is fixed

Sign in to add a comment