The classes and comments which make up the remote security key functioanlity contain a mixture of old and new terms (gnubby and security key). We should update as much of it as possible to use the new term).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/281516541a3aa129b5a23c29cdfb926c99f3d516 commit 281516541a3aa129b5a23c29cdfb926c99f3d516 Author: joedow <joedow@chromium.org> Date: Wed Jul 20 01:05:47 2016 Renaming Gnubby and RemoteSecurityKey files/classes/members This change is a simple refactoring to rename the 'Gnubby' and 'RemoteSecurityKey' file/class names/comments/etc to be consistent. I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey (which was causing too many 80 char limit issues). No functional changes are expected as a result of this change. Note: Not every instance of Gnubby or RemoteSecurityKey has been changed. The registry key used for toggling this functionality still uses 'gnubby'. I don't want to change that here. Also, the process used on the host machine is still called remote_security_key so classes associated with that process were not renamed (neither were the IPC messages used by it). BUG= 593736 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2162083003 Cr-Commit-Position: refs/heads/master@{#406435} [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/PRESUBMIT.py [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/BUILD.gn [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/host_mock_objects.cc [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/host_mock_objects.h [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/remoting_me2me_host.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/fake_ipc_gnubby_auth_handler.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_ipc_security_key_auth_handler.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_ipc_security_key_auth_handler.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/fake_remote_security_key_ipc_server.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/fake_remote_security_key_message_reader.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/fake_remote_security_key_message_writer.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_ipc_client.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_ipc_client.h [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_ipc_server.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_ipc_server.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_message_reader.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_message_reader.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_message_writer.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/fake_security_key_message_writer.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/gnubby_auth_handler.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/gnubby_auth_handler_linux.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/gnubby_auth_handler_win_unittest.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/gnubby_extension.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/gnubby_extension_session.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_ipc_constants.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_ipc_constants.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_ipc_server.h [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/remote_security_key_main.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_handler.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_handler.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_handler_unittest.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_writer.cc [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_writer.h [delete] https://crrev.com/754bc6ad217229061bd025b770527583683c8b3e/remoting/host/security_key/remote_security_key_message_writer_impl.h [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_android.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_linux.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_linux_unittest.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_mac.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_win.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_auth_handler_win_unittest.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_extension.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_extension.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_extension_session.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_extension_session.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_extension_session_unittest.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_client.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_client.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_client_unittest.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_constants.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_constants.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_server.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_server.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_server_impl.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_server_impl.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_ipc_server_unittest.cc [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message.cc [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message.h [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_handler.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_handler.h [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_handler_unittest.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_reader.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_reader.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_reader_impl.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_reader_impl.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_reader_impl_unittest.cc [copy] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_writer.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_writer.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_writer_impl.cc [add] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_writer_impl.h [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_message_writer_impl_unittest.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_socket.cc [rename] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/host/security_key/security_key_socket.h [modify] https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516/remoting/remoting_host_srcs.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/552673170a62f6f01a07556bae129ca768ce006a commit 552673170a62f6f01a07556bae129ca768ce006a Author: hayato <hayato@chromium.org> Date: Wed Jul 20 01:35:33 2016 Revert of Renaming Gnubby and RemoteSecurityKey files/classes/members (patchset #3 id:40001 of https://codereview.chromium.org/2162083003/ ) Reason for revert: Build break: https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/builds/1194 Original issue's description: > Renaming Gnubby and RemoteSecurityKey files/classes/members > > This change is a simple refactoring to rename the 'Gnubby' and > 'RemoteSecurityKey' file/class names/comments/etc to be consistent. > I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey > (which was causing too many 80 char limit issues). No functional > changes are expected as a result of this change. > > Note: Not every instance of Gnubby or RemoteSecurityKey has been > changed. The registry key used for toggling this functionality still > uses 'gnubby'. I don't want to change that here. Also, the process > used on the host machine is still called remote_security_key so classes > associated with that process were not renamed (neither were the IPC > messages used by it). > > BUG= 593736 > TBR=jochen@chromium.org > > Committed: https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516 > Cr-Commit-Position: refs/heads/master@{#406435} TBR=sergeyu@chromium.org,joedow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 593736 Review-Url: https://codereview.chromium.org/2167473003 Cr-Commit-Position: refs/heads/master@{#406440} [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/PRESUBMIT.py [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/BUILD.gn [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/host_mock_objects.cc [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/host_mock_objects.h [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/remoting_me2me_host.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_ipc_gnubby_auth_handler.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_ipc_gnubby_auth_handler.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/fake_ipc_security_key_auth_handler.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_ipc_client.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_ipc_client.h [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_ipc_server.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_ipc_server.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_message_reader.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_message_reader.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_message_writer.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/fake_remote_security_key_message_writer.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/fake_security_key_ipc_server.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/fake_security_key_message_reader.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/fake_security_key_message_writer.h [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_android.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_linux.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_linux_unittest.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_mac.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_win.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_auth_handler_win_unittest.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_extension.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_extension.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_extension_session.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_extension_session.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_extension_session_unittest.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_socket.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/gnubby_socket.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_client.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_client.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_client_unittest.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_constants.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_constants.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_server.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_server.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_server_impl.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_server_impl.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_ipc_server_unittest.cc [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_main.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_handler.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_handler.h [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_handler_unittest.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_reader.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_reader.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_reader_impl.cc [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_reader_impl.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_reader_impl_unittest.cc [copy] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_writer.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_writer.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_writer_impl.cc [add] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_writer_impl.h [rename] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/remote_security_key_message_writer_impl_unittest.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_auth_handler.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_auth_handler_linux.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_auth_handler_win_unittest.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_extension.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_extension_session.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_ipc_constants.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_ipc_constants.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_ipc_server.h [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/security_key_message.cc [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/host/security_key/security_key_message.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_handler.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_handler.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_handler_unittest.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_writer.cc [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_writer.h [delete] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/remoting/host/security_key/security_key_message_writer_impl.h [modify] https://crrev.com/552673170a62f6f01a07556bae129ca768ce006a/remoting/remoting_host_srcs.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9ab1dfecef1bf316d51fc934a47d6b3de6837e commit be9ab1dfecef1bf316d51fc934a47d6b3de6837e Author: joedow <joedow@chromium.org> Date: Thu Jul 21 00:06:45 2016 Renaming Gnubby and RemoteSecurityKey files/classes/members This change is a simple refactoring to rename the 'Gnubby' and 'RemoteSecurityKey' file/class names/comments/etc to be consistent. I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey (which was causing too many 80 char limit issues). No functional changes are expected as a result of this change. Note: Not every instance of Gnubby or RemoteSecurityKey has been changed. The registry key used for toggling this functionality still uses 'gnubby'. I don't want to change that here. Also, the process used on the host machine is still called remote_security_key so classes associated with that process were not renamed (neither were the IPC messages used by it). BUG= 593736 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2164753004 Cr-Commit-Position: refs/heads/master@{#406718} [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/PRESUBMIT.py [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/BUILD.gn [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/host_mock_objects.cc [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/host_mock_objects.h [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/remoting_me2me_host.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/fake_ipc_gnubby_auth_handler.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_ipc_security_key_auth_handler.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_ipc_security_key_auth_handler.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/fake_remote_security_key_ipc_server.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/fake_remote_security_key_message_reader.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/fake_remote_security_key_message_writer.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_ipc_client.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_ipc_client.h [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_ipc_server.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_ipc_server.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_message_reader.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_message_reader.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_message_writer.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/fake_security_key_message_writer.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/gnubby_auth_handler.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/gnubby_auth_handler_linux.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/gnubby_auth_handler_win_unittest.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/gnubby_extension.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/gnubby_extension_session.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_ipc_constants.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_ipc_constants.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_ipc_server.h [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/remote_security_key_main.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_handler.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_handler.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_handler_unittest.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_writer.cc [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_writer.h [delete] https://crrev.com/6302068a9d5156a5a17278ff14d868ffc3cf6546/remoting/host/security_key/remote_security_key_message_writer_impl.h [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_android.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_linux.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_linux_unittest.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_mac.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_win.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_auth_handler_win_unittest.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_extension.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_extension.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_extension_session.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_extension_session.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_extension_session_unittest.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_client.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_client.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_client_unittest.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_constants.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_constants.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_server.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_server.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_server_impl.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_server_impl.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_ipc_server_unittest.cc [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message.cc [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message.h [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_handler.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_handler.h [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_handler_unittest.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_reader.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_reader.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_reader_impl.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_reader_impl.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_reader_impl_unittest.cc [copy] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_writer.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_writer.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_writer_impl.cc [add] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_writer_impl.h [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_message_writer_impl_unittest.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_socket.cc [rename] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/host/security_key/security_key_socket.h [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/remoting_host_srcs.gypi [modify] https://crrev.com/be9ab1dfecef1bf316d51fc934a47d6b3de6837e/remoting/remoting_test.gypi
Comment 1 by joedow@chromium.org
, Apr 15 2016