New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2011
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Creating multiple audio elements interrupts other audio elements

Reported by richt...@gmail.com, Oct 15 2010

Issue description

Chrome Version       : 8.0.552.0 dev
URLs (if applicable) : http://github.com/richtaur/chrome_audio and http://richtaur.com/misc/dev/chrome_audio/

What steps will reproduce the problem?
1. Open `sfx_and_music.html`
2. Press the `final_battle.mp3` button
3. Repeatedly press the `bat_damage.mp3` button (or any of the other buttons)

What is the expected result?
"Final music" should continue playing in the background, uninterrupted by the other audio elements on the page.

What happens instead?
"Final music" stops abruptly.
 
Labels: -Area-Undefined Area-WebKit OS-All Mstone-9 Feature-Media
Status: Available
Which OS are you using?
Labels: -Mstone-9 Mstone-10
Status: Assigned

Comment 3 by kerz@chromium.org, Dec 9 2010

Labels: -Mstone-10 MovedFrom-10 Mstone-11
P2 bugs with an owner that are not marked as started are being automatically moved to mstone:11.
Hey are you still having issues with this?
Labels: -MovedFrom-10 HelpWanted
Status: Available
Hey are you still having issues with this?
As of [10.0.648.18 (Official Build 73584) on glucid] expected behavior occurs - multiple mp3's overlap and the clicking one doesn't make previously-playing ones stop.  Resolve?

Comment 7 by *sjl@chromium.org, Feb 10 2011

Still repros for me on OSX 10.0.648.45 (dev channel).

Comment 8 by mal@google.com, Feb 14 2011

Labels: -HelpWanted GoodFirstBug
Labels: -Pri-2 -Mstone-11 Pri-1 Mstone-12
Labels: -GoodFirstBug bulkmove Hotlist-GoodFirstBug
Chrome Version       : 8.0.552.0 dev
URLs (if applicable) : http://github.com/richtaur/chrome_audio and http://richtaur.com/misc/dev/chrome_audio/

What steps will reproduce the problem?
1. Open `sfx_and_music.html`
2. Press the `final_battle.mp3` button
3. Repeatedly press the `bat_damage.mp3` button (or any of the other buttons)

What is the expected result?
"Final music" should continue playing in the background, uninterrupted by the other audio elements on the page.

What happens instead?
"Final music" stops abruptly.
Labels: -Mstone-12 Mstone-13
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 14 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=81669

------------------------------------------------------------------------
r81669 | davej@chromium.org | Thu Apr 14 16:31:33 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_output.cc?r1=81669&r2=81668&pathrev=81669
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_output_unittest.cc?r1=81669&r2=81668&pathrev=81669

Fix Linux audio playback

Playing audio files shorter than about 11000 samples on Linux was either not working at all, or re-playing (starting and stopping on the same audio object) was working only intermittently.  It was possible to stop audio playback before the first buffer was played, resulting in no sound at all.  Also, if replaying, the buffer may have been dirty from the previous playback on the same device.

So on Linux at least, these issues appear fixed.

BUG= 73045 , 47761 , 59367 , 59369 , 59370 , 65618 
TEST=Manual, quickly playing short audio files on Linux should work

Review URL: http://codereview.chromium.org/6776024
------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 14 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=81670

------------------------------------------------------------------------
r81670 | davej@chromium.org | Thu Apr 14 16:34:00 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.h?r1=81670&r2=81669&pathrev=81670
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/audio_output_dispatcher.cc?r1=81670&r2=81669&pathrev=81670
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/audio_output_dispatcher.h?r1=81670&r2=81669&pathrev=81670
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.cc?r1=81670&r2=81669&pathrev=81670

Fix erratic HTML5 audio playback

This was affecting all platforms.  The major issue was that he SetPlaybackRate(1) which is used to start playback was being done in the middle of the series of Seek operations.  So doing Seek() followed by SetPlaybackRate(1) was done, the Seek could immediately stop the playback.  To fix, Seek() was made atomic with regards to SetPlaybackRate() by delaying the execution of SetPlaybackRate until after the Seek sequence has completely finished.

To make things run even smoother, a short delay was added before recyclilng a used audio stream in the Dispatcher.  This gives the stream time to 'power down' before being reused.

Tested on Linux, Chrome-OS (Cr48) and Mac with great results, making HTML5 audio much more usable for games.

BUG= 73045 , 59369 , 59370 , 65618 
TEST=Manual, Quickly playing/stopping HTML5 audio should play cleanly.

Review URL: http://codereview.chromium.org/6822019
------------------------------------------------------------------------

Comment 14 by davej@chromium.org, Apr 19 2011

Owner: scherkus@chromium.org
Status: Fixed
It looks like r81669 and r81670 fix this.
Labels: ImportantForGames
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -Feature-Media -Mstone-13 Cr-Content Cr-Internals-Media M-13
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Sign in to add a comment