New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593693 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 673589



Sign in to add a comment

UI for next/previous button is not proper for find in page box.

Reported by vku...@etouch.net, Mar 10 2016

Issue description

Chrome Version: 51.0.2673.0 (Official Build)Revision 764e6bb1b05458cde3ca0702ceb801d25c3dcc3b-refs/heads/master@{#380313} (64-bit)
OS:Mac

Precondition: Select 'Material' option for 'Material design in the browser's top chrome.

What steps will reproduce the problem?
1.Launch chrome and open NTP.
2.Press cmd+F key from keyboard to open find in page and observe on top/bottom of next/previous button.

Actual: UI for next/previous button is not proper for find in page (i.e vertical line is not visible instead only dot is seen)

Expected: UI for next/previous button should be properly displayed.

This is a regression issue broken in 'M51' and will soon update other info.

 

Comment 1 by vku...@etouch.net, Mar 10 2016

Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 51.02663.0
Bad Build: 51.02664.0

Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/5121a34129f274edc61a288f73f99b39eb06e1e7..b38be38cee2027dcb827ebc61abb23508b8e5d25?pretty=fuller&n=10

Suspecting: 378367 ?

Note: Issue not seen on Win & Linux OS.
Actual_Result.png
253 KB View Download

Comment 2 by vku...@etouch.net, Mar 10 2016

Labels: hasbisect
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 4 by shrike@chromium.org, Mar 10 2016

Labels: -ReleaseBlock-Stable Proj-MaterialDesign-NativeUI
Summary: UI for next/previous button is not proper for find in page box. (was: Regression:UI for next/previous button is not proper for find in page box. )
This is not a regression, per se - it looks like the vertical line is not being drawn when you activate the Material Design flag. This is not code I have worked on or changed so I will have to dig around for the cause or the proper owner.

Comment 5 by shrike@chromium.org, Mar 10 2016

Cc: -ranjitkan@chromium.org shrike@chromium.org
Owner: ranjitkan@chromium.org
Status: Untriaged (was: Assigned)
Actually, can you find someone to look into this? This is not code that I touched. I'm assuming that the in-page find bar is looking for the Material Design flag and drawing itself a bit differently when it's turned on. Someone who has worked on the in-page find code should take a look at it.

Cc: ranjitkan@chromium.org msw@chromium.org
Owner: ----
@msw: Adding you in the loop, request you to please take a look into it. Please help us in reassign to the right owner for the issue raised.

Comment 7 by msw@chromium.org, Mar 14 2016

Cc: pkasting@chromium.org est...@chromium.org
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
estade, pkasting?

Comment 8 by est...@chromium.org, Mar 14 2016

Owner: shrike@chromium.org
I only ever touched the Views version of the find in page bar. I don't think anyone has touched the mac FIP code recently, so it seems like shrike's work is the likeliest culprit (or at least qualifies him as a good candidate for tracking down the source of the regression, if it wasn't r378367)

Comment 9 by meh...@chromium.org, Mar 14 2016

Only a note: The separator is also missing in Non-MaterialDesign Mode.


Bildschirmfoto 2016-03-14 um 21.47.21.png
70.7 KB View Download
Owner: ----
Status: Untriaged (was: Assigned)
This us not a result of any of my changes, and should be assigned to someone familiar with the Find in page code for triage.
Labels: -Proj-MaterialDesign-NativeUI
... and already broken in Chrome Stable Version 49.0.2623.87 (64-bit)
Labels: -Pri-1 -hasbisect -M-51 M-49 Pri-2
Owner: pinkerton@chromium.org
Status: Assigned (was: Untriaged)
Labels: Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)

Comment 14 by vku...@etouch.net, Mar 15 2016

Labels: -Needs-Bisect -M-49 -Type-Bug-Regression M-51 Type-Bug
With response to comment #11 & 13

Rechecked again and found that its seen from M30 series(i.e 30.0.1549.0) with following steps.
1.Launch chrome and open NTP.
2.Press cmd+F key and enter any letter e.g 't', observe separator
3.Enter complete letter e.g 'test' and observe separator

Actual: 
1.Separator appears after entering single letter i.e after step 1&2
2.It vanishes once complete text 'test/tes' is entered.

Please refer attached screenshot & video
With Seperator.png
38.2 KB View Download
Without Seperator.png
32.8 KB View Download
Seperator.mov
4.1 MB Download
Labels: -Pri-2 -M-51 Hotlist-Polish Hotlist-GoodFirstBug Pri-3
Removing milestone, P3 (since it's been around for 20 milestones already). 
Status: Available (was: Untriaged)
Project Member

Comment 17 by sheriffbot@chromium.org, Mar 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Blockedon: 673589
Project Member

Comment 20 by sheriffbot@chromium.org, Apr 16 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Available)
Updates:
Rechecked the above issue on Mac (10.13.1, 10.13.6, 10.14.2) OS using latest Canary build #72.0.3609.3 and the issue not reproducible.
New Find in bubble is seen, hence issue is not reproducible.
Kindly refer the attached screen-cast.
Thank You
Canary#72.0.3609.3.mov
5.7 MB View Download

Sign in to add a comment